From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory
Date: Fri, 1 May 2015 18:39:14 -0400 [thread overview]
Message-ID: <20150501223913.GA1179@peff.net> (raw)
In-Reply-To: <CAGZ79kYNR6JNU=vVL_Pp0axFX_cpu1Bi5x226GUbeFdum9wkZg@mail.gmail.com>
On Fri, May 01, 2015 at 03:33:13PM -0700, Stefan Beller wrote:
> > Probably all of the other sites touched by be65e7d could use the same
> > treatment.
>
> I looked around, just as Eric suggested as well and found those too.
> I don't think I'll track down the history of when this change became possible,
> but I'd rather point to (f5114a40c0d0, 2011-08-04, git-check-attr:
> Normalize paths),
> where the result of prefix_path is freed unconditionally already.
Ah, right. I noticed there were two extras in be65e7d that Eric hadn't
mentioned, but I didn't actually check to see if they were already
fixed. It looks like they are (further evidence that this is a good
thing to be doing :) ).
-Peff
next prev parent reply other threads:[~2015-05-01 22:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 19:28 [PATCH] checkout-index.c: Unconditionally free memory Stefan Beller
2015-05-01 19:33 ` Eric Sunshine
2015-05-01 19:41 ` Eric Sunshine
2015-05-01 19:50 ` Jeff King
2015-05-01 22:33 ` Stefan Beller
2015-05-01 22:39 ` Jeff King [this message]
2015-05-01 22:35 ` Stefan Beller
2015-05-01 22:43 ` Jeff King
2015-05-03 2:15 ` Junio C Hamano
2015-05-03 2:30 ` Jeff King
2015-05-03 3:03 ` Junio C Hamano
2015-05-01 23:41 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501223913.GA1179@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.