From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory
Date: Sat, 2 May 2015 22:30:24 -0400 [thread overview]
Message-ID: <20150503023024.GA4269@peff.net> (raw)
In-Reply-To: <xmqqpp6iwgnn.fsf@gitster.dls.corp.google.com>
On Sat, May 02, 2015 at 07:15:08PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > On Fri, May 01, 2015 at 03:35:37PM -0700, Stefan Beller wrote:
> >
> >> Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory
> >
> > Looks like the patch has expanded beyond checkout-index.c. Maybe:
> >
> > unconditionally free result of prefix_path
> >
> > would be more descriptive? I usually like the "area:" prefix, but I
> > think here the common thread is not an area, but that they are return
> > values from prefix_path.
>
> Sure, the prefix could even be "prefix_path(): $message", I would
> think.
I almost suggested that, but it not a change to prefix_path at all, but
rather to its callers. That may be getting nit-picky, though. :)
-Peff
next prev parent reply other threads:[~2015-05-03 2:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 19:28 [PATCH] checkout-index.c: Unconditionally free memory Stefan Beller
2015-05-01 19:33 ` Eric Sunshine
2015-05-01 19:41 ` Eric Sunshine
2015-05-01 19:50 ` Jeff King
2015-05-01 22:33 ` Stefan Beller
2015-05-01 22:39 ` Jeff King
2015-05-01 22:35 ` Stefan Beller
2015-05-01 22:43 ` Jeff King
2015-05-03 2:15 ` Junio C Hamano
2015-05-03 2:30 ` Jeff King [this message]
2015-05-03 3:03 ` Junio C Hamano
2015-05-01 23:41 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150503023024.GA4269@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.