Linux device driver for USB WIFI needs integrating

Linux device driver for USB WIFI needs integrating

[Chris Ward]

There is a Linux driver here
http://www.asus.com/Networking/USBN10_NANO/HelpDesk_download/ that needs
integrating into the 'kernel.org' source. Please can you pass this to
whoever should do this.

Do we need formal permission from ASUS, or do we just take it ?

Please cc: me on any replies as I am not subscribed to the LKML.

Thanks !

Chris Ward

-- 
ResearchGate: https://www.researchgate.net/profile/Thomas_Ward16
Portfolio: http://tjcw.freeshell.org/Portfolio/

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Anders Larsen]

On 2015-04-24 12:37, Chris Ward wrote:
> There is a Linux driver here
> http://www.asus.com/Networking/USBN10_NANO/HelpDesk_download/ that  
> needs
> integrating into the 'kernel.org' source.

Isn't that device supported by the in-tree RTL8192CU/RTL8188CU driver?
(CONFIG_RTL8192CU, drivers/net/wireless/rtlwifi/rtl8192cu/)

If it isn't, it should only be a matter of adding the USB Id of the
ASUS device.

> Do we need formal permission from ASUS, or do we just take it ?

AFAICT the archive ASUS has made available contains a driver authored
by RealTek, so that would be where to ask.

The source files contains a statement that they are covered by GPLv2,
so formally you would not have to ask - although I'd consider it in
good taste to do so.

Cheers
Anders

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

I just got a trap when booting the current OpenSUSE kernel (in the
insmod), so something is not right. 3.16.7-21 , I think
--

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

(this was having installed the ASUS driver and plugged my WIFI card in)

Chris.
--

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

lsusb shows
Bus 003 Device 024: ID 0b05:17ba ASUSTek Computer, Inc.

I've just built the OpenSUSE kernel from source, it has that CONFIG=m .
I think ASUS have changed the chip set.

Do we have to wait for ASUS to debug their driver ? Supposedly it worked
with an older kernel (up to 3.10 I think)

Chris Ward
--
Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Anders Larsen]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

On 2015-04-24 13:59, Chris Ward wrote:
> lsusb shows
> Bus 003 Device 024: ID 0b05:17ba ASUSTek Computer, Inc.

OK, thanks

> I've just built the OpenSUSE kernel from source, it has that CONFIG=m  
> .
> I think ASUS have changed the chip set.

only the USB id AFAICT - 0b05:17ab is supported

> Do we have to wait for ASUS to debug their driver ? Supposedly it  
> worked
> with an older kernel (up to 3.10 I think)

does the attached trivial patch help?
(it should make the in-tree driver recognise your ASUS device)

Cheers
Anders

[-- Attachment #2: 0001-rtlwifi-rtl8192cu-Add-USB-id-for-ASUS-USB-N10-NANO.patch --]
[-- Type: text/x-patch, Size: 1232 bytes --]

=46rom 2d7ede77347f9e2f00b248839961b3da311a27fa Mon Sep 17 00:00:00 2001
From: Anders Larsen <al@alarsen.net>
Date: Fri, 24 Apr 2015 14:17:33 +0200
Subject: [PATCH] rtlwifi/rtl8192cu: Add USB id for ASUS USB-N10 NANO

"ASUS USB-N10 NANO" wifi adapter USB id: 0b05:17ba

Signed-off-by: Anders Larsen <al@alarsen.net>
---
 drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
index 1ac6383..77c4b62 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
@@ -364,6 +364,7 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
 	{RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/
 	{RTL_USB_DEVICE(0x0846, 0xf001, rtl92cu_hal_cfg)}, /*On Netwrks N300MA*/
 	{RTL_USB_DEVICE(0x0b05, 0x17ab, rtl92cu_hal_cfg)}, /*ASUS-Edimax*/
+	{RTL_USB_DEVICE(0x0b05, 0x17ba, rtl92cu_hal_cfg)}, /*ASUS-Edimax N10 nano*/
 	{RTL_USB_DEVICE(0x0bda, 0x8186, rtl92cu_hal_cfg)}, /*Realtek 92CE-VAU*/
 	{RTL_USB_DEVICE(0x0df6, 0x0061, rtl92cu_hal_cfg)}, /*Sitecom-Edimax*/
 	{RTL_USB_DEVICE(0x0e66, 0x0019, rtl92cu_hal_cfg)}, /*Hawking-Edimax*/
-- 
2.3.6

Re: Linux device driver for USB WIFI needs integrating

[Anders Larsen]

On 2015-04-24 14:25, Anders Larsen wrote:
> On 2015-04-24 13:59, Chris Ward wrote:
>> lsusb shows
>> Bus 003 Device 024: ID 0b05:17ba ASUSTek Computer, Inc.
> 
> does the attached trivial patch help?
> (it should make the in-tree driver recognise your ASUS device)

I just realised that the above USB id was already added to the
in-tree driver - it should appear the next Kernel release.
(commit 9374e7d2fdcad3c36dafc8d3effd554bc702c4b6 in Linus' tree)

If my patch (which does exactly the same as the above) works for you
we can ask for that commit to be added to the stable kernels, so please
let us know how you proceed.

Cheers
Anders

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

No, with the patch the device isn't recognised at boot time.

Chris
-- 
ResearchGate: https://www.researchgate.net/profile/Thomas_Ward16
Portfolio: http://tjcw.freeshell.org/Portfolio/

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Anders Larsen]

On 2015-04-24 19:31, Chris Ward wrote:
> No, with the patch the device isn't recognised at boot time.

Strange.

Does the module 'rtl8192cu' get loaded automatically (check with  
'lsmod')?
What happens if you wait until the system is booted, then plug the  
device?

Could you put your '.config' and the output from 'dmesg' and 'lsusb -v'  
(with the device plugged in) on a server somewhere and post a link here?
(If not, send me the files in a private mail, then I'll post the  
relevant parts on the list)

Cheers
Anders

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

I have put the requested files in http://tjcw.freeshell.org/usbn10/ . The
ones with 'after' in the name are with the device plugged in at boot.
There is also a Belkin WiFi adapter plugged in , because I need networking
active in order to write this email.

Cheers !

Chris Ward
-- 
ResearchGate: https://www.researchgate.net/profile/Thomas_Ward16
Portfolio: http://tjcw.freeshell.org/Portfolio/

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Anders Larsen]

On 2015-04-27 10:38, Chris Ward wrote:
> I have put the requested files in http://tjcw.freeshell.org/usbn10/ .  
> The
> ones with 'after' in the name are with the device plugged in at boot.

well, .config contains
> CONFIG_RTL8192CU=m
so the driver is built.

and dmesg contains
> usb 3-2: new high-speed USB device number 2 using xhci_hcd
> usb 3-2: New USB device found, idVendor=0b05, idProduct=17ba
> usb 3-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-2: Product: 802.11n WLAN Adapter
> usb 3-2: Manufacturer: Realtek
> usb 3-2: SerialNumber: 00e04c000001
so the device is recognised (at USB level).

The module 'rtl8192cu.ko' isn't loaded as expected, however.

Perhaps it wasn't installed correctly - the USB id should have an entry  
in /lib/modules/3.16.7-21/modules.alias of the form 'alias  
usb:v0B05p17BAd*dc*dsc*dp*ic*isc*ip*in* rtl8192cu'
('grep usb:v0B05p17BA /lib/modules/*/modules.alias' should show it)

If the entry is missing, it must appear after the alias file is  
regenerated (with 'depmod -a').

If it's there, but the module is still not loaded when you plug the  
device, please try to load it manually (with 'modprobe -v rtl8192cu  
debug=5') and check dmesg again.

Cheers
Anders

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

'dempod' doesn't makethe module appear:

tjcw@linux-7ke7:~> grep usb:v0B05p17BA /lib/modules/*/modules.alias
tjcw@linux-7ke7:~> su
Password:
linux-7ke7:/home/tjcw # depmod -a
linux-7ke7:/home/tjcw # exit
tjcw@linux-7ke7:~> grep usb:v0B05p17BA /lib/modules/*/modules.alias
tjcw@linux-7ke7:~>

-- 
ResearchGate: https://www.researchgate.net/profile/Thomas_Ward16
Portfolio: http://tjcw.freeshell.org/Portfolio/

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

There is this
alias usb:v0B05p17ABd*dc*dsc*dp*ic*isc*ip*in* rtl8192cu

is there a typo in the patch file you posted ?

-- 
ResearchGate: https://www.researchgate.net/profile/Thomas_Ward16
Portfolio: http://tjcw.freeshell.org/Portfolio/

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

Looks like your patch wasn't installed. I have patched the sw.c file and
am rebuilding

Chris.
-- 
ResearchGate: https://www.researchgate.net/profile/Thomas_Ward16
Portfolio: http://tjcw.freeshell.org/Portfolio/

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Chris Ward]

With the patch actually applied, the WiFi adapter is recognised and works,
both on boot and if the adapter is plugged in later. So, all is well.

What mainline kernel level will contain the patch ?

Thanks !

Chris Ward.

-- 
ResearchGate: https://www.researchgate.net/profile/Thomas_Ward16
Portfolio: http://tjcw.freeshell.org/Portfolio/

Disclaimer: I work for IBM, but I do not represent IBM. Any opinions
expressed in this email are personal and don’t necessarily represent my
employer’s positions, strategies or opinions.

Re: Linux device driver for USB WIFI needs integrating

[Anders Larsen]

On 2015-04-27 16:23, Chris Ward wrote:
> With the patch actually applied, the WiFi adapter is recognised and  
> works,
> both on boot and if the adapter is plugged in later. So, all is well.

glad to hear that - and thanks for testing!

> What mainline kernel level will contain the patch ?

Marek (CC'ed) added the USB ID some 4 weeks ago, so it's scheduled for  
the upcoming 4.1

@Marek: can we get your commit 9374e7d2 added to the stable kernels,  
please?
(the full discussion with Chris is archived here:  
https://lkml.org/lkml/2015/4/24/156)

Cheers
Anders

Re: Linux device driver for USB WIFI needs integrating

[Marek Vasut]

On Monday, April 27, 2015 at 04:49:09 PM, Anders Larsen wrote:
> On 2015-04-27 16:23, Chris Ward wrote:
> > With the patch actually applied, the WiFi adapter is recognised and
> > works,
> > both on boot and if the adapter is plugged in later. So, all is well.
> 
> glad to hear that - and thanks for testing!
> 
> > What mainline kernel level will contain the patch ?
> 
> Marek (CC'ed) added the USB ID some 4 weeks ago, so it's scheduled for
> the upcoming 4.1
> 
> @Marek: can we get your commit 9374e7d2 added to the stable kernels,
> please?
> (the full discussion with Chris is archived here:
> https://lkml.org/lkml/2015/4/24/156)

Feel free to apply for stable. I also tested the patch on Linux 3.10.5x
so it ought to work all the way back to at least 3.10.

Best regards,
Marek Vasut

Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Anders Larsen]

Hi,

commit 9374e7d2fdcad3c36dafc8d3effd554bc702c4b6
Author: Marek Vasut <marex@denx.de>
Date:   2015-03-26 02:16:06 +0100

     rtlwifi: rtl8192cu: Add new device ID

     Add new ID for ASUS N10 WiFi dongle.

in Linus' tree has been tested on 3.16.7 and 3.10.5x
and applies cleanly all the way back to 3.2.68

Please consider this patch for the stable trees.

Thanks,
Anders

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Marek Vasut]

On Tuesday, April 28, 2015 at 03:56:04 PM, Anders Larsen wrote:
> Hi,
> 
> commit 9374e7d2fdcad3c36dafc8d3effd554bc702c4b6
> Author: Marek Vasut <marex@denx.de>
> Date:   2015-03-26 02:16:06 +0100
> 
>      rtlwifi: rtl8192cu: Add new device ID
> 
>      Add new ID for ASUS N10 WiFi dongle.
> 
> in Linus' tree has been tested on 3.16.7 and 3.10.5x
> and applies cleanly all the way back to 3.2.68
> 
> Please consider this patch for the stable trees.

Hi,

did you check [1] please? I might be wrong, but these are
the official -stable submission guidelines to my knowledge.

[1] https://www.kernel.org/doc/Documentation/stable_kernel_rules.txt

Best regards,
Marek Vasut

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Anders Larsen]

On 2015-04-28 16:10, Marek Vasut wrote:
> did you check [1] please? I might be wrong, but these are
> the official -stable submission guidelines to my knowledge.
> 
> [1] https://www.kernel.org/doc/Documentation/stable_kernel_rules.txt

sure I did - networking has its own stable submission guidelines in
Documentation/networking/netdev-FAQ.txt

Cheers
Anders

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Marek Vasut]

On Tuesday, April 28, 2015 at 04:22:34 PM, Anders Larsen wrote:
> On 2015-04-28 16:10, Marek Vasut wrote:
> > did you check [1] please? I might be wrong, but these are
> > the official -stable submission guidelines to my knowledge.
> > 
> > [1] https://www.kernel.org/doc/Documentation/stable_kernel_rules.txt
> 
> sure I did - networking has its own stable submission guidelines in
> Documentation/networking/netdev-FAQ.txt

I apologize, thank you for pointing this out, I will educate myself.

Best regards,
Marek Vasut

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Marek Vasut]

On Tuesday, April 28, 2015 at 04:22:34 PM, Anders Larsen wrote:
> On 2015-04-28 16:10, Marek Vasut wrote:
> > did you check [1] please? I might be wrong, but these are
> > the official -stable submission guidelines to my knowledge.
> > 
> > [1] https://www.kernel.org/doc/Documentation/stable_kernel_rules.txt
> 
> sure I did - networking has its own stable submission guidelines in
> Documentation/networking/netdev-FAQ.txt

I apologize, thank you for pointing this out, I will educate myself.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Larry Finger]

Please note that there are two commits just added to the mainline repo that 
should be propagated to all stable kernels. Both are addition of new USB IDs for 
an old driver, thus they will cause to side effects. Unfortunately, the Cc to 
stable was missed in the first of these, thus the need for this message. The 
second was Cc for stable, but I include it here for completeness.

The two commits in question are

commit 9374e7d2fdcad3c36dafc8d3effd554bc702c4b6
Author: Marek Vasut <marex@denx.de>
Date:   Thu Mar 26 02:16:06 2015 +0100

     rtlwifi: rtl8192cu: Add new device ID

     Add new ID for ASUS N10 WiFi dongle.

commit 2f92b314f4daff2117847ac5343c54d3d041bf78
Author: Larry Finger <Larry.Finger@lwfinger.net>
Date:   Mon Mar 23 18:14:10 2015 -0500

     rtlwifi: rtl8192cu: Add new USB ID

     USB ID 2001:330d is used for a D-Link DWA-131.


Thanks,

Larry

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Luis Henriques]

On Tue, Apr 28, 2015 at 10:23:28AM -0500, Larry Finger wrote:
> Please note that there are two commits just added to the mainline repo that
> should be propagated to all stable kernels. Both are addition of new USB IDs
> for an old driver, thus they will cause to side effects. Unfortunately, the
> Cc to stable was missed in the first of these, thus the need for this
> message. The second was Cc for stable, but I include it here for
> completeness.
> 
> The two commits in question are
> 
> commit 9374e7d2fdcad3c36dafc8d3effd554bc702c4b6
> Author: Marek Vasut <marex@denx.de>
> Date:   Thu Mar 26 02:16:06 2015 +0100
> 
>     rtlwifi: rtl8192cu: Add new device ID
> 
>     Add new ID for ASUS N10 WiFi dongle.
> 
> commit 2f92b314f4daff2117847ac5343c54d3d041bf78
> Author: Larry Finger <Larry.Finger@lwfinger.net>
> Date:   Mon Mar 23 18:14:10 2015 -0500
> 
>     rtlwifi: rtl8192cu: Add new USB ID
> 
>     USB ID 2001:330d is used for a D-Link DWA-131.
> 
>

Thank you, Larry.  Queuing both patches for the 3.16 kernel.

Cheers,
--
Luís

> Thanks,
> 
> Larry
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Luis Henriques]

On Tue, Apr 28, 2015 at 10:23:28AM -0500, Larry Finger wrote:
> Please note that there are two commits just added to the mainline repo that
> should be propagated to all stable kernels. Both are addition of new USB IDs
> for an old driver, thus they will cause to side effects. Unfortunately, the
> Cc to stable was missed in the first of these, thus the need for this
> message. The second was Cc for stable, but I include it here for
> completeness.
> 
> The two commits in question are
> 
> commit 9374e7d2fdcad3c36dafc8d3effd554bc702c4b6
> Author: Marek Vasut <marex@denx.de>
> Date:   Thu Mar 26 02:16:06 2015 +0100
> 
>     rtlwifi: rtl8192cu: Add new device ID
> 
>     Add new ID for ASUS N10 WiFi dongle.
> 
> commit 2f92b314f4daff2117847ac5343c54d3d041bf78
> Author: Larry Finger <Larry.Finger@lwfinger.net>
> Date:   Mon Mar 23 18:14:10 2015 -0500
> 
>     rtlwifi: rtl8192cu: Add new USB ID
> 
>     USB ID 2001:330d is used for a D-Link DWA-131.
> 
>

Thank you, Larry.  Queuing both patches for the 3.16 kernel.

Cheers,
--
Lu�s

> Thanks,
> 
> Larry
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Stable request 9374e7d2 "rtlwifi: rtl8192cu: Add new device ID"

[Luis Henriques]

On Tue, Apr 28, 2015 at 10:23:28AM -0500, Larry Finger wrote:
> Please note that there are two commits just added to the mainline repo that
> should be propagated to all stable kernels. Both are addition of new USB IDs
> for an old driver, thus they will cause to side effects. Unfortunately, the
> Cc to stable was missed in the first of these, thus the need for this
> message. The second was Cc for stable, but I include it here for
> completeness.
> 
> The two commits in question are
> 
> commit 9374e7d2fdcad3c36dafc8d3effd554bc702c4b6
> Author: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> Date:   Thu Mar 26 02:16:06 2015 +0100
> 
>     rtlwifi: rtl8192cu: Add new device ID
> 
>     Add new ID for ASUS N10 WiFi dongle.
> 
> commit 2f92b314f4daff2117847ac5343c54d3d041bf78
> Author: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
> Date:   Mon Mar 23 18:14:10 2015 -0500
> 
>     rtlwifi: rtl8192cu: Add new USB ID
> 
>     USB ID 2001:330d is used for a D-Link DWA-131.
> 
>

Thank you, Larry.  Queuing both patches for the 3.16 kernel.

Cheers,
--
Luís

> Thanks,
> 
> Larry
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Linux device driver for USB WIFI needs integrating

[Anders Larsen]

On Monday, 27. April 2015 16:49:09 Anders Larsen wrote:
> On 2015-04-27 16:23, Chris Ward wrote:
> > What mainline kernel level will contain the patch ?
> 
> Marek (CC'ed) added the USB ID some 4 weeks ago, so it's scheduled for  
> the upcoming 4.1

FYI yesterday Marek's patch was accepted into the stable queues (3.10.x, 
3.14.x, 3.19.x and 4.0.x), so it will probably hit most distros in the next 
few weeks.

Cheers
Anders