From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] x86, stackvalidate: Add asm frame pointer setup macros
Date: Mon, 4 May 2015 16:14:43 -0500 [thread overview]
Message-ID: <20150504211443.GC12638@treble.redhat.com> (raw)
In-Reply-To: <5547D7B1.8070703@zytor.com>
On Mon, May 04, 2015 at 01:33:53PM -0700, H. Peter Anvin wrote:
> On 05/04/2015 01:23 PM, Josh Poimboeuf wrote:
> > + __ASM_SIZE(push, _cfi) %_ASM_BP
> > + __ASM_SIZE(pop, _cfi) %_ASM_BP
>
> This seems ridiculous. push/pop only come in one size per
> architecture(*). Can we make it so that just push_cfi and pop_cfi do
> the right things?
Yeah, the separated pushq_cfi and pushl_cfi macros aren't really
necessary. I'm guessing they were made separate in order to have a
consistent naming interface with movq_cfi and movl_cfi.
I'm not sure about which way is better. But I can replace them with new
push_cfi and pop_cfi macros if you like.
--
Josh
prev parent reply other threads:[~2015-05-04 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 20:23 [PATCH v2 0/2] Compile-time stack frame pointer validation Josh Poimboeuf
2015-05-04 20:23 ` [PATCH v2 1/2] x86, stackvalidate: " Josh Poimboeuf
2015-05-04 20:23 ` [PATCH v2 2/2] x86, stackvalidate: Add asm frame pointer setup macros Josh Poimboeuf
2015-05-04 20:33 ` H. Peter Anvin
2015-05-04 21:14 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504211443.GC12638@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.