From: "H. Peter Anvin" <hpa@zytor.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Cc: Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] x86, stackvalidate: Add asm frame pointer setup macros
Date: Mon, 04 May 2015 13:33:53 -0700 [thread overview]
Message-ID: <5547D7B1.8070703@zytor.com> (raw)
In-Reply-To: <df0e393755bfb792872d8e649bf802baff6b2407.1430770553.git.jpoimboe@redhat.com>
On 05/04/2015 01:23 PM, Josh Poimboeuf wrote:
> + __ASM_SIZE(push, _cfi) %_ASM_BP
> + __ASM_SIZE(pop, _cfi) %_ASM_BP
This seems ridiculous. push/pop only come in one size per
architecture(*). Can we make it so that just push_cfi and pop_cfi do
the right things?
-hpa
(*) Intentionally ignoring 16 bit here...
next prev parent reply other threads:[~2015-05-04 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 20:23 [PATCH v2 0/2] Compile-time stack frame pointer validation Josh Poimboeuf
2015-05-04 20:23 ` [PATCH v2 1/2] x86, stackvalidate: " Josh Poimboeuf
2015-05-04 20:23 ` [PATCH v2 2/2] x86, stackvalidate: Add asm frame pointer setup macros Josh Poimboeuf
2015-05-04 20:33 ` H. Peter Anvin [this message]
2015-05-04 21:14 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547D7B1.8070703@zytor.com \
--to=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.