All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave P Martin <Dave.Martin@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Andrew Jackson <Andrew.Jackson@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] serial/amba-pl011: fix minor bugs for pio mode
Date: Tue, 5 May 2015 12:11:56 +0100	[thread overview]
Message-ID: <20150505111155.GA16868@e103592.cambridge.arm.com> (raw)
In-Reply-To: <1430794825-14367-1-git-send-email-leo.yan@linaro.org>

Hi,

On Tue, May 05, 2015 at 04:00:25AM +0100, Leo Yan wrote:
> When use pio mode, there have two issues can be observed:
> 
> - In the commit 2240197 "serial/amba-pl011: Leave the TX IRQ alone when
>   the UART is not open", it will skip clearing the TX IRQ across
>   pl011_shutdown() and pl011_startup(); So at the next time after the
>   uart port has been opened, there have chance for the function
>   pl011_tx_chars() will not be executed if the TX IRQ will not be
>   triggered; finally the console cannot output anymore.
> 
>   This is caused by the uart FIFO still keep data rather than
>   the threshold. So revert this patch to make sure every time open the
>   uart port, it will force to call function pl011_tx_chars().
> 
> - Sometimes will output the duplicate chars. Function pl011_tx_char()
>   will firstly send char and check if FIFO is full, and if the FIFO is
>   full it will return false; Caller function will consider the char
>   has _NOT_ been send out and resend it again, finally will send the
>   duplicate chars. So change to check FIFO is full or not, if full then
>   return false, otherwise send out char and return true.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>

[...]

Thanks for the fixes, but I already posted patches that probably fix the
issues you are observing, And Greg took them into his tty-testing branch.

Can you give them a try instead of your patches?

Dave Martin (2):
      Revert "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open"
      serial/amba-pl011: Refactor and simplify TX FIFO handling

from

git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing


It would be good to have some feedback on them.

Cheers
---Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave.Martin@arm.com (Dave P Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial/amba-pl011: fix minor bugs for pio mode
Date: Tue, 5 May 2015 12:11:56 +0100	[thread overview]
Message-ID: <20150505111155.GA16868@e103592.cambridge.arm.com> (raw)
In-Reply-To: <1430794825-14367-1-git-send-email-leo.yan@linaro.org>

Hi,

On Tue, May 05, 2015 at 04:00:25AM +0100, Leo Yan wrote:
> When use pio mode, there have two issues can be observed:
> 
> - In the commit 2240197 "serial/amba-pl011: Leave the TX IRQ alone when
>   the UART is not open", it will skip clearing the TX IRQ across
>   pl011_shutdown() and pl011_startup(); So at the next time after the
>   uart port has been opened, there have chance for the function
>   pl011_tx_chars() will not be executed if the TX IRQ will not be
>   triggered; finally the console cannot output anymore.
> 
>   This is caused by the uart FIFO still keep data rather than
>   the threshold. So revert this patch to make sure every time open the
>   uart port, it will force to call function pl011_tx_chars().
> 
> - Sometimes will output the duplicate chars. Function pl011_tx_char()
>   will firstly send char and check if FIFO is full, and if the FIFO is
>   full it will return false; Caller function will consider the char
>   has _NOT_ been send out and resend it again, finally will send the
>   duplicate chars. So change to check FIFO is full or not, if full then
>   return false, otherwise send out char and return true.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>

[...]

Thanks for the fixes, but I already posted patches that probably fix the
issues you are observing, And Greg took them into his tty-testing branch.

Can you give them a try instead of your patches?

Dave Martin (2):
      Revert "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open"
      serial/amba-pl011: Refactor and simplify TX FIFO handling

from

git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing


It would be good to have some feedback on them.

Cheers
---Dave

  parent reply	other threads:[~2015-05-05 11:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05  3:00 [PATCH] serial/amba-pl011: fix minor bugs for pio mode Leo Yan
2015-05-05  3:00 ` Leo Yan
2015-05-05 11:02 ` Daniel Thompson
2015-05-05 11:02   ` Daniel Thompson
2015-05-05 11:11 ` Dave P Martin [this message]
2015-05-05 11:11   ` Dave P Martin
2015-05-05 12:09   ` Leo Yan
2015-05-05 12:09     ` Leo Yan
2015-05-05 12:11     ` Leo Yan
2015-05-05 12:11       ` Leo Yan
2015-05-05 12:23       ` Dave Martin
2015-05-05 12:23         ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150505111155.GA16868@e103592.cambridge.arm.com \
    --to=dave.martin@arm.com \
    --cc=Andrew.Jackson@arm.com \
    --cc=leo.yan@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.