From: Dave Chinner <david@fromorbit.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfstests: btrfs: test device replace, with EIO on the src dev
Date: Wed, 6 May 2015 09:11:30 +1000 [thread overview]
Message-ID: <20150505231130.GM15810@dastard> (raw)
In-Reply-To: <5548DE28.6070209@oracle.com>
On Tue, May 05, 2015 at 11:13:44PM +0800, Anand Jain wrote:
>
> Dave,
>
> Thanks for comments. I am rewriting it.
>
> But any idea why should _scratch_mkfs_dmerror (below) should
> fail with one of the device in SCRATCH_DEV_POOL being busy.?
> (when I start the script non of the device provided is actually
> busy).
$SCRATCH_DEV is the first device in $SCRATCH_DEV_POOL, right?
> +SCRATCH_DEV_POOL_DEV1="`echo $SCRATCH_DEV_POOL | $AWK_PROG '{print $1}'`"
> +SCRATCH_DEV_POOL_DEV2="`echo $SCRATCH_DEV_POOL | $AWK_PROG '{print $2}'`"
BTW, don't shout so much in your code: dev1 and dev2 are perfectly
good local variable names. In general, local variables are in lower
case, global/exported variables are in upper case.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-05-05 23:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 10:08 [PATCH 0/3] dm error based test cases Anand Jain
2015-04-30 10:08 ` [PATCH 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-05-04 23:46 ` Dave Chinner
2015-04-30 10:08 ` [PATCH 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-05-05 0:14 ` Dave Chinner
2015-05-05 15:13 ` Anand Jain
2015-05-05 23:11 ` Dave Chinner [this message]
2015-04-30 10:08 ` [PATCH 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-05-05 19:03 ` [PATCH v2 0/3] dm error based test cases Anand Jain
2015-05-05 19:03 ` [PATCH v2 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-05-05 22:22 ` [PATCH v2.1 " Anand Jain
2015-05-05 19:03 ` [PATCH v2 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-05-06 8:54 ` Filipe David Manana
2015-05-05 19:03 ` [PATCH v2 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-08-07 10:31 ` Filipe David Manana
2015-08-13 14:35 ` Anand Jain
2015-05-11 13:49 ` [PATCH v3 0/3] dm error based test cases Anand Jain
2015-05-11 13:49 ` [PATCH v3 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-05-11 13:49 ` [PATCH v3 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-05-11 13:49 ` [PATCH v3 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-07-22 10:12 ` [PATCH v4 0/3] dm error based test cases Anand Jain
2015-07-22 10:12 ` [PATCH v4 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-07-22 10:12 ` [PATCH v4 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-07-22 10:12 ` [PATCH v4 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-07-22 10:14 ` [PATCH v4 0/3] dm error based test cases Anand Jain
2015-07-22 10:14 ` [PATCH v4 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-08-07 10:26 ` Filipe David Manana
2015-08-13 14:39 ` Anand Jain
2015-07-22 10:14 ` [PATCH v4 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-08-07 10:27 ` Filipe David Manana
2015-08-13 14:43 ` Anand Jain
2015-07-22 10:14 ` [PATCH v4 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505231130.GM15810@dastard \
--to=david@fromorbit.com \
--cc=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.