All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: fdmanana@gmail.com
Cc: fstests@vger.kernel.org,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"dsterba@suse.cz" <dsterba@suse.cz>,
	Dave Chinner <david@fromorbit.com>,
	sandeen@sandeen.net
Subject: Re: [PATCH v4 2/3] xfstests: btrfs: test device replace, with EIO on the src dev
Date: Thu, 13 Aug 2015 22:43:28 +0800	[thread overview]
Message-ID: <55CCAD10.5070907@oracle.com> (raw)
In-Reply-To: <CAL3q7H5=Oy3qfFt4DTaxCRBNfBW5YfHmcRbCsW3BBbBO7Z3J3w@mail.gmail.com>




> So the test always fails due to a mismatch with this expected golden output:
>
>      -Label: none  uuid: <UUID>
>      +Label: none  uuid:  <UUID>
>        Total devices <NUM> FS bytes used <SIZE>
>        devid <DEVID> size <SIZE> used <SIZE> path SCRATCH_DEV
>        devid <DEVID> size <SIZE> used <SIZE> path /dev/mapper/error-test
>
> The extra space after "uuid:" comes from _filter_uuid:
>
>     sed -e "s/\(uuid[ :=]\+\) *[0-9a-f-][0-9a-f-]*/\1 <UUID>/ig"
>
> Which gets \1 with the string "uuid: " and then does "uuid: " + " " + "<UUID>".
>
> We need to either to fix the golden output here or _filter_uuid (and
> make sure it doesn't break any other tests using it directly or
> indirectly such as yours).

commit a092363bbdfa6cc6e44353136bae9d3aa81baae2 (PATCH 3/3 V6] xfs: test 
changing UUID on V5 superblock) caused the regression. btrfs/006 is 
affected as well.

   Thanks
Anand

  reply	other threads:[~2015-08-13 14:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 10:08 [PATCH 0/3] dm error based test cases Anand Jain
2015-04-30 10:08 ` [PATCH 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-05-04 23:46   ` Dave Chinner
2015-04-30 10:08 ` [PATCH 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-05-05  0:14   ` Dave Chinner
2015-05-05 15:13     ` Anand Jain
2015-05-05 23:11       ` Dave Chinner
2015-04-30 10:08 ` [PATCH 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-05-05 19:03 ` [PATCH v2 0/3] dm error based test cases Anand Jain
2015-05-05 19:03   ` [PATCH v2 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-05-05 22:22     ` [PATCH v2.1 " Anand Jain
2015-05-05 19:03   ` [PATCH v2 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-05-06  8:54     ` Filipe David Manana
2015-05-05 19:03   ` [PATCH v2 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-08-07 10:31     ` Filipe David Manana
2015-08-13 14:35       ` Anand Jain
2015-05-11 13:49 ` [PATCH v3 0/3] dm error based test cases Anand Jain
2015-05-11 13:49 ` [PATCH v3 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-05-11 13:49 ` [PATCH v3 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-05-11 13:49 ` [PATCH v3 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-07-22 10:12 ` [PATCH v4 0/3] dm error based test cases Anand Jain
2015-07-22 10:12   ` [PATCH v4 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-07-22 10:12   ` [PATCH v4 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-07-22 10:12   ` [PATCH v4 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-07-22 10:14 ` [PATCH v4 0/3] dm error based test cases Anand Jain
2015-07-22 10:14   ` [PATCH v4 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-08-07 10:26     ` Filipe David Manana
2015-08-13 14:39       ` Anand Jain
2015-07-22 10:14   ` [PATCH v4 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-08-07 10:27     ` Filipe David Manana
2015-08-13 14:43       ` Anand Jain [this message]
2015-07-22 10:14   ` [PATCH v4 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CCAD10.5070907@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=david@fromorbit.com \
    --cc=dsterba@suse.cz \
    --cc=fdmanana@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.