Re: [PATCH v2 0/3] Dell Airplane Mode Switch driver

["Pali Rohár" <pali.rohar@gmail.com>]

On Tuesday 05 May 2015 13:37:10 Darren Hart wrote:
> On Sun, May 03, 2015 at 12:38:14PM +0200, Pali Rohár wrote:
> > On Wednesday 29 April 2015 11:51:03 Pali Rohár wrote:
> > > This patch series add new acpi Dell Airplane Mode Switch
> > > driver (DELLABCE and DELRBTN acpi devices). It provides radio
> > > HW switch events (together with current state of radio
> > > devices) and export them via rfkill interface. These events
> > > are also used in dell-laptop driver instead i8042 filter hook
> > > function (when acpi device is available).
> > > 
> > > In v2 was added support for laptops which have toggle button
> > > instead HW slider switch. For that I reused code done by Alex
> > > Hung.
> > > 
> > > Pali Rohár (3):
> > >   platform: x86: dell-rbtn: Dell Airplane Mode Switch driver
> > >   platform: x86: dell-rbtn: Export notifier for other kernel
> > > modules platform: x86: dell-laptop: Use dell-rbtn instead
> > > i8042 filter when possible
> > > 
> > >  drivers/platform/x86/Kconfig       |   14 ++
> > >  drivers/platform/x86/Makefile      |    1 +
> > >  drivers/platform/x86/dell-laptop.c |   67 +++++-
> > >  drivers/platform/x86/dell-rbtn.c   |  430
> > > ++++++++++++++++++++++++++++++++++++
> > > drivers/platform/x86/dell-rbtn.h   |   35 +++
> > >  5 files changed, 542 insertions(+), 5 deletions(-)
> > >  create mode 100644 drivers/platform/x86/dell-rbtn.c
> > >  create mode 100644 drivers/platform/x86/dell-rbtn.h
> > 
> > Alex, can you rested this patch series on all your machines like 
> > you did previous in this sheet?
> > 
> > https://docs.google.com/spreadsheets/d/1voffS6dNglwAExSGh3UmG__UAO2qfZ829CkJLPo06aI/edit?usp=sharing
> > 
> > Ideally do more tests:
> > 1) only with first patch 1/3
> > 2) with full patch series 1/3, 2/3, 3/3 *with* loaded dell-laptop
> > 3) same as 2) but without loaded dell-laptop
> > 
> > If everything pass then this patch series is OK from my side.
> > 
> > Looks like Gabriele's problem is irrelevant to this patch series, 
> > but we probably hit some rfkill bug in dell-laptop.ko :-(
> > 
> > Matthew or Darren, can you review code in this patch series? So 
> > if everything will be fine, dell-rbtn could be ready for 4.2.
> 
> Yes - but I need some additional context.
> 
> There wasn't a "Since v1..." changelog below the --- line in the patches. It's
> always good practice to include it - but especially after this much time has
> passed - it really helps page back in all the relevant issues.
> 

2/3 and 3/3 patches were not changed (just rebased). And to patch 1/3
was added input device for reporting wireless toggle button (for laptops
which have toggle button instead hw slider switch). Plus patch contains
some code cleanup.

> After the discussion on this list, I'm not sure where we are with how this patch
> series impacts the machines that Alex and Garbiele are working on.
> 

As wrote in previous email, now we are waiting for Alex's tests to make
sure that everything is working fine as expected.

> What I would like is this: amongst yourselves, please agree on a solution and
> provide a patch series with a Signed-off-by from the author(s) and at least a
> Tested-by from the others.
> 
> If this is it, each of you please reply here stating as much.
> 
> Thanks,
> 

-- 
Pali Rohár
pali.rohar@gmail.com