All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Ulianov <mikhail.ulyanov@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: hverkuil@xs4all.nl, horms@verge.net.au, magnus.damm@gmail.com,
	sergei.shtylyov@cogentembedded.com, linux-media@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver
Date: Wed, 06 May 2015 05:46:49 +0000	[thread overview]
Message-ID: <20150506084649.3bc76d27@bones> (raw)
In-Reply-To: <5004544.CpPfGJfHMn@avalon>

On Mon, 04 May 2015 02:32:05 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Mikhail,
> 
> Thank you for the patch. Please see below for a (partial) review.
> 
> On Thursday 30 April 2015 00:53:29 Mikhail Ulyanov wrote:
> > Here's the the driver for the Renesas R-Car JPEG processing unit
> > driver.
> > 
> > The driver is implemented within the V4L2 framework as a mem-to-mem
> > device. It presents two video nodes to userspace, one for the
> > encoding part, and one for the decoding part.
> > 
> > It was found that the only working mode for encoding is no markers
> > output, so we generate it with software. In current version of
> > driver we also use software JPEG header parsing because with
> > hardware parsing performance is lower then desired.
> 
> Just out of curiosity, what is the performance impact of hardware
> parsing ?
Looks like feature of IP core. Header parsing complete/continue
sequence make it work 1.5-2 times longer, so as i remember maximum
performance with 1Mp YUV420 JPEG decoding was ~60 FPS. 

WARNING: multiple messages have this Message-ID (diff)
From: Mikhail Ulianov <mikhail.ulyanov@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: hverkuil@xs4all.nl, horms@verge.net.au, magnus.damm@gmail.com,
	sergei.shtylyov@cogentembedded.com, linux-media@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver
Date: Wed, 6 May 2015 08:46:49 +0300	[thread overview]
Message-ID: <20150506084649.3bc76d27@bones> (raw)
In-Reply-To: <5004544.CpPfGJfHMn@avalon>

On Mon, 04 May 2015 02:32:05 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Mikhail,
> 
> Thank you for the patch. Please see below for a (partial) review.
> 
> On Thursday 30 April 2015 00:53:29 Mikhail Ulyanov wrote:
> > Here's the the driver for the Renesas R-Car JPEG processing unit
> > driver.
> > 
> > The driver is implemented within the V4L2 framework as a mem-to-mem
> > device. It presents two video nodes to userspace, one for the
> > encoding part, and one for the decoding part.
> > 
> > It was found that the only working mode for encoding is no markers
> > output, so we generate it with software. In current version of
> > driver we also use software JPEG header parsing because with
> > hardware parsing performance is lower then desired.
> 
> Just out of curiosity, what is the performance impact of hardware
> parsing ?
Looks like feature of IP core. Header parsing complete/continue
sequence make it work 1.5-2 times longer, so as i remember maximum
performance with 1Mp YUV420 JPEG decoding was ~60 FPS. 

  parent reply	other threads:[~2015-05-06  5:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 21:53 [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver Mikhail Ulyanov
2015-04-29 21:53 ` Mikhail Ulyanov
2015-04-29 21:59 ` Sergei Shtylyov
2015-04-29 21:59   ` Sergei Shtylyov
2015-04-29 22:08   ` Sergei Shtylyov
2015-04-29 22:08     ` Sergei Shtylyov
2015-05-03 10:21 ` Hans Verkuil
2015-05-03 10:21   ` Hans Verkuil
2015-05-03 23:32 ` Laurent Pinchart
2015-05-03 23:32   ` Laurent Pinchart
2015-05-05 22:03   ` Mikhail Ulianov
2015-05-05 22:03     ` Mikhail Ulianov
2015-06-18 19:48     ` Laurent Pinchart
2015-06-18 19:48       ` Laurent Pinchart
2015-06-22 14:54       ` Kamil Debski
2015-06-22 14:54         ` Kamil Debski
2015-06-26 11:34         ` Mikhail Ulyanov
2015-06-26 11:34           ` Mikhail Ulyanov
2015-06-26 12:14           ` Kamil Debski
2015-06-26 12:14             ` Kamil Debski
2015-06-26 12:23             ` Mikhail Ulyanov
2015-06-26 12:23               ` Mikhail Ulyanov
2015-05-06  5:46   ` Mikhail Ulianov [this message]
2015-05-06  5:46     ` Mikhail Ulianov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150506084649.3bc76d27@bones \
    --to=mikhail.ulyanov@cogentembedded.com \
    --cc=horms@verge.net.au \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.