From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Cc: Kukjin Kim <kgene@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] input: s3c2410_ts: Constify platform_device_id
Date: Wed, 6 May 2015 16:55:47 -0700 [thread overview]
Message-ID: <20150506235547.GF5580@dtor-ws> (raw)
In-Reply-To: <1430495587-31762-2-git-send-email-k.kozlowski.k@gmail.com>
On Sat, May 02, 2015 at 12:53:07AM +0900, Krzysztof Kozlowski wrote:
> The platform_device_id is not modified by the driver and core uses it as
> const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> ---
> drivers/input/touchscreen/s3c2410_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index bdfa27dc097b..a4a103e1d11b 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -411,7 +411,7 @@ static const struct dev_pm_ops s3c_ts_pmops = {
> };
> #endif
>
> -static struct platform_device_id s3cts_driver_ids[] = {
> +static const struct platform_device_id s3cts_driver_ids[] = {
> { "s3c2410-ts", 0 },
> { "s3c2440-ts", 0 },
> { "s3c64xx-ts", FEAT_PEN_IRQ },
> --
> 2.1.4
>
Applied both, thank you.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] input: s3c2410_ts: Constify platform_device_id
Date: Wed, 6 May 2015 16:55:47 -0700 [thread overview]
Message-ID: <20150506235547.GF5580@dtor-ws> (raw)
In-Reply-To: <1430495587-31762-2-git-send-email-k.kozlowski.k@gmail.com>
On Sat, May 02, 2015 at 12:53:07AM +0900, Krzysztof Kozlowski wrote:
> The platform_device_id is not modified by the driver and core uses it as
> const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> ---
> drivers/input/touchscreen/s3c2410_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index bdfa27dc097b..a4a103e1d11b 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -411,7 +411,7 @@ static const struct dev_pm_ops s3c_ts_pmops = {
> };
> #endif
>
> -static struct platform_device_id s3cts_driver_ids[] = {
> +static const struct platform_device_id s3cts_driver_ids[] = {
> { "s3c2410-ts", 0 },
> { "s3c2440-ts", 0 },
> { "s3c64xx-ts", FEAT_PEN_IRQ },
> --
> 2.1.4
>
Applied both, thank you.
--
Dmitry
next prev parent reply other threads:[~2015-05-06 23:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 15:53 [PATCH 1/2] input: samsung-keypad: Constify platform_device_id Krzysztof Kozlowski
2015-05-01 15:53 ` Krzysztof Kozlowski
2015-05-01 15:53 ` [PATCH 2/2] input: s3c2410_ts: " Krzysztof Kozlowski
2015-05-01 15:53 ` Krzysztof Kozlowski
2015-05-06 23:55 ` Dmitry Torokhov [this message]
2015-05-06 23:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506235547.GF5580@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=k.kozlowski.k@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.