From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Eran Harary <eran.harary@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
Kalle Valo <kvalo@codeaurora.org>, Arik Nemtsov <arik@wizery.com>,
Luciano Coelho <luciano.coelho@intel.com>,
Liad Kaufman <liad.kaufman@intel.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlwifi: mvm: remove some dead code
Date: Thu, 07 May 2015 12:42:25 +0000 [thread overview]
Message-ID: <20150507124224.GX16501@mwanda> (raw)
In-Reply-To: <1431001635.11214.2.camel@sipsolutions.net>
On Thu, May 07, 2015 at 02:27:15PM +0200, Johannes Berg wrote:
> On Thu, 2015-05-07 at 12:58 +0300, Dan Carpenter wrote:
> > "ret" is zero here so we can remove this stray check.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/net/wireless/iwlwifi/mvm/fw.c b/drivers/net/wireless/iwlwifi/mvm/fw.c
> > index df86963..41f4763 100644
> > --- a/drivers/net/wireless/iwlwifi/mvm/fw.c
> > +++ b/drivers/net/wireless/iwlwifi/mvm/fw.c
> > @@ -663,8 +663,6 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
> > */
> > _iwl_trans_stop_device(mvm->trans, false);
> > _iwl_trans_start_hw(mvm->trans, false);
> > - if (ret)
> > - return ret;
>
> It looks like "ret = _iwl_trans_start_hw(...)" was intended though?
>
Hm... You may be right. Should it also be "goto error;" instead of a
direct return? I'm not positive. Eran can you fix this and give me a
Reported-by tag?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Eran Harary <eran.harary@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
Kalle Valo <kvalo@codeaurora.org>, Arik Nemtsov <arik@wizery.com>,
Luciano Coelho <luciano.coelho@intel.com>,
Liad Kaufman <liad.kaufman@intel.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlwifi: mvm: remove some dead code
Date: Thu, 7 May 2015 15:42:25 +0300 [thread overview]
Message-ID: <20150507124224.GX16501@mwanda> (raw)
In-Reply-To: <1431001635.11214.2.camel@sipsolutions.net>
On Thu, May 07, 2015 at 02:27:15PM +0200, Johannes Berg wrote:
> On Thu, 2015-05-07 at 12:58 +0300, Dan Carpenter wrote:
> > "ret" is zero here so we can remove this stray check.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/net/wireless/iwlwifi/mvm/fw.c b/drivers/net/wireless/iwlwifi/mvm/fw.c
> > index df86963..41f4763 100644
> > --- a/drivers/net/wireless/iwlwifi/mvm/fw.c
> > +++ b/drivers/net/wireless/iwlwifi/mvm/fw.c
> > @@ -663,8 +663,6 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
> > */
> > _iwl_trans_stop_device(mvm->trans, false);
> > _iwl_trans_start_hw(mvm->trans, false);
> > - if (ret)
> > - return ret;
>
> It looks like "ret = _iwl_trans_start_hw(...)" was intended though?
>
Hm... You may be right. Should it also be "goto error;" instead of a
direct return? I'm not positive. Eran can you fix this and give me a
Reported-by tag?
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-07 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 9:58 [patch] iwlwifi: mvm: remove some dead code Dan Carpenter
2015-05-07 9:58 ` Dan Carpenter
2015-05-07 12:27 ` Johannes Berg
2015-05-07 12:27 ` Johannes Berg
2015-05-07 12:42 ` Dan Carpenter [this message]
2015-05-07 12:42 ` Dan Carpenter
2015-05-07 12:47 ` Johannes Berg
2015-05-07 12:47 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507124224.GX16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arik@wizery.com \
--cc=emmanuel.grumbach@intel.com \
--cc=eran.harary@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=liad.kaufman@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.