From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Michael Welling <mwelling-EkmVulN54Sk@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects
Date: Thu, 7 May 2015 20:27:58 +0100 [thread overview]
Message-ID: <20150507192758.GR22845@sirena.org.uk> (raw)
In-Reply-To: <20150507192019.GA15112@deathray>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote:
> On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote:
> > makes things easier to review and helps people trying to understand the
> Do you have any other suggestions or comments on the patch so that I
> can incorporate those changes as well in the patch series?
No, that's part of the "easier to review" bit.
> I noticed a few oddities in the code when converting.
> For instance:
> http://lxr.free-electrons.com/source/drivers/spi/spi-omap2-mcspi.c#L1225
> What is the point of trying to print tx or rx given the if statement
> insures that rx_buff and tx_buff are NULL?
I expect it's just a buggy test.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Michael Welling <mwelling@ieee.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects
Date: Thu, 7 May 2015 20:27:58 +0100 [thread overview]
Message-ID: <20150507192758.GR22845@sirena.org.uk> (raw)
In-Reply-To: <20150507192019.GA15112@deathray>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote:
> On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote:
> > makes things easier to review and helps people trying to understand the
> Do you have any other suggestions or comments on the patch so that I
> can incorporate those changes as well in the patch series?
No, that's part of the "easier to review" bit.
> I noticed a few oddities in the code when converting.
> For instance:
> http://lxr.free-electrons.com/source/drivers/spi/spi-omap2-mcspi.c#L1225
> What is the point of trying to print tx or rx given the if statement
> insures that rx_buff and tx_buff are NULL?
I expect it's just a buggy test.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-07 19:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 23:37 [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects Michael Welling
2015-05-06 23:37 ` Michael Welling
[not found] ` <1430955472-11409-1-git-send-email-mwelling-EkmVulN54Sk@public.gmane.org>
2015-05-07 18:58 ` Mark Brown
2015-05-07 18:58 ` Mark Brown
2015-05-07 19:20 ` Michael Welling
2015-05-07 19:27 ` Mark Brown [this message]
2015-05-07 19:27 ` Mark Brown
[not found] ` <20150507192758.GR22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-07 19:38 ` Michael Welling
2015-05-07 19:38 ` Michael Welling
2015-05-07 19:56 ` Mark Brown
2015-05-07 19:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507192758.GR22845@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mwelling-EkmVulN54Sk@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.