From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Benjamin Romer <benjamin.romer@unisys.com>,
linux-kernel@vger.kernel.org, sparmaintainer@unisys.com
Subject: Re: [PATCH 2/2] staging: unisys: remove unused variable
Date: Fri, 8 May 2015 10:34:49 +0300 [thread overview]
Message-ID: <20150508073449.GM14154@mwanda> (raw)
In-Reply-To: <20150508042444.GA3192@sudip-PC>
On Fri, May 08, 2015 at 09:54:44AM +0530, Sudip Mukherjee wrote:
> On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
> > > the previous patch of the series made this variable unused.
> >
> > What do you mean? There was only one other patch in this series, never
> > send a patch that causes a build warning.
> This patch is 2/2 , the 1/2 patch when applied will cause a build
> warning about unused variable.
>
> should i then send a v2 mentioning that "1/2 will cause a build warning
> which is fixed in 2/2" ?
>
Gar... No. Fold them together into one patch...
The one thing per patch rule means that you shouldn't do half a thing
per patch.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-08 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 9:36 [PATCH 1/2] staging: unisys: remove unused functions Sudip Mukherjee
2015-05-07 9:36 ` [PATCH 2/2] staging: unisys: remove unused variable Sudip Mukherjee
2015-05-07 20:04 ` Greg Kroah-Hartman
2015-05-08 4:24 ` Sudip Mukherjee
2015-05-08 7:19 ` Greg Kroah-Hartman
2015-05-08 7:34 ` Dan Carpenter [this message]
2015-05-08 7:54 ` Sudip Mukherjee
2015-05-08 9:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508073449.GM14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benjamin.romer@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.