From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benjamin Romer <benjamin.romer@unisys.com>,
sparmaintainer@unisys.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: unisys: remove unused variable
Date: Fri, 8 May 2015 12:04:02 +0300 [thread overview]
Message-ID: <20150508090402.GR14154@mwanda> (raw)
In-Reply-To: <20150508075413.GA7663@sudip-PC>
On Fri, May 08, 2015 at 01:24:32PM +0530, Sudip Mukherjee wrote:
> so, what i understood till now:
> 1) any patch of the series should not break the build.
> (you told me that in my parport patch series :) )
>
> 2) any patch of the series should not introduce build warning.
>
> 3) when i am modifying some line, i can make simple changes in style.
> but if its big change in style then that should be a separate
> patch.
>
Yes.
regards,
carpenter
prev parent reply other threads:[~2015-05-08 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 9:36 [PATCH 1/2] staging: unisys: remove unused functions Sudip Mukherjee
2015-05-07 9:36 ` [PATCH 2/2] staging: unisys: remove unused variable Sudip Mukherjee
2015-05-07 20:04 ` Greg Kroah-Hartman
2015-05-08 4:24 ` Sudip Mukherjee
2015-05-08 7:19 ` Greg Kroah-Hartman
2015-05-08 7:34 ` Dan Carpenter
2015-05-08 7:54 ` Sudip Mukherjee
2015-05-08 9:04 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508090402.GR14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benjamin.romer@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.