From: Michael Welling <mwelling-EkmVulN54Sk@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS
Date: Fri, 8 May 2015 12:37:37 -0500 [thread overview]
Message-ID: <20150508173737.GA5991@deathray> (raw)
In-Reply-To: <20150508170916.GD2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Fri, May 08, 2015 at 06:09:16PM +0100, Mark Brown wrote:
> On Thu, May 07, 2015 at 06:36:54PM -0500, Michael Welling wrote:
>
> > + if (gpio_is_valid(spi->cs_gpio)) {
> > + if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0)
> > + gpio_direction_output(spi->cs_gpio,
> > + !(spi->mode & SPI_CS_HIGH));
> > + }
>
> I'm not seeing anything that frees this GPIO?
Ooops I forgot to add this to the cleanup function.
It appears that the transfer_one patch got applied so how should I
provide the new version of this patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Michael Welling <mwelling@ieee.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS
Date: Fri, 8 May 2015 12:37:37 -0500 [thread overview]
Message-ID: <20150508173737.GA5991@deathray> (raw)
In-Reply-To: <20150508170916.GD2761@sirena.org.uk>
On Fri, May 08, 2015 at 06:09:16PM +0100, Mark Brown wrote:
> On Thu, May 07, 2015 at 06:36:54PM -0500, Michael Welling wrote:
>
> > + if (gpio_is_valid(spi->cs_gpio)) {
> > + if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0)
> > + gpio_direction_output(spi->cs_gpio,
> > + !(spi->mode & SPI_CS_HIGH));
> > + }
>
> I'm not seeing anything that frees this GPIO?
Ooops I forgot to add this to the cleanup function.
It appears that the transfer_one patch got applied so how should I
provide the new version of this patch?
next prev parent reply other threads:[~2015-05-08 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 23:36 [PATCH v4 0/2] spi: omap2-mcspi: Add support for GPIO chipselects Michael Welling
2015-05-07 23:36 ` Michael Welling
2015-05-07 23:36 ` [PATCH v4 1/2] spi: omap2-mcspi: Switch driver to use transfer_one Michael Welling
2015-05-08 16:59 ` Mark Brown
2015-05-07 23:36 ` [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS Michael Welling
[not found] ` <1431041814-24757-3-git-send-email-mwelling-EkmVulN54Sk@public.gmane.org>
2015-05-08 17:09 ` Mark Brown
2015-05-08 17:09 ` Mark Brown
[not found] ` <20150508170916.GD2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-08 17:37 ` Michael Welling [this message]
2015-05-08 17:37 ` Michael Welling
2015-05-08 17:53 ` Mark Brown
2015-05-08 17:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508173737.GA5991@deathray \
--to=mwelling-ekmvuln54sk@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.