Re: [Qemu-devel] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere

[Kevin Wolf <kwolf@redhat.com>]

Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben:
> Instead of checking bs->sg use bdrv_is_sg() consistently throughout
> the code.
> 
> Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block.c           |    6 +++---
>  block/iscsi.c     |    2 +-
>  block/raw-posix.c |    4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)

> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 24d8582..24b061f 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -302,9 +302,9 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp)
>      BDRVRawState *s = bs->opaque;
>      char *buf;
>  
> -    /* For /dev/sg devices the alignment is not really used.
> +    /* For SG devices the alignment is not really used.
>         With buffered I/O, we don't have any restrictions. */

If you want to change this comment, why not "SCSI generic" instead of
letting people guess what sg might mean in this context?

Kevin