From: Eric Blake <eblake@redhat.com>
To: Dimitris Aragiorgis <dimara@arrikto.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT
Date: Mon, 11 May 2015 10:52:22 -0600 [thread overview]
Message-ID: <5550DE46.8090907@redhat.com> (raw)
In-Reply-To: <554D1837.10505@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On 05/08/2015 02:10 PM, Eric Blake wrote:
> On 05/08/2015 11:47 AM, Dimitris Aragiorgis wrote:
>> Building the QEMU tools fails if we #define DEBUG_BLOCK inside
>> block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
>> so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
>> a simple DPRINTF().
>>
> Please fix this to ensure that we avoid bit-rot even when debugging is
> not turned on. Something like:
>
> #ifdef DEBUG_BLOCK
> # define DEBUG_BLOCK_PRINT 1
> #else
> # define DEBUG_BLOCK_PRINT 0
> #endif
> #define DPRINTF(fmt, ...) \
> do \
> if (DEBUG_BLOCK_PRINT) { \
> printf(fmt, ## __VA_ARGS__); \
> while (0)
Obviously, with the missing } that allows compilation :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-05-11 16:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 17:47 [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic Dimitris Aragiorgis
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere Dimitris Aragiorgis
2015-05-11 10:04 ` Kevin Wolf
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic Dimitris Aragiorgis
2015-05-11 10:12 ` Kevin Wolf
2015-05-14 11:02 ` Dimitris Aragiorgis
2015-05-14 13:21 ` Paolo Bonzini
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT Dimitris Aragiorgis
2015-05-08 20:10 ` Eric Blake
2015-05-11 16:52 ` Eric Blake [this message]
2015-05-11 10:16 ` Kevin Wolf
2015-05-11 10:21 ` Paolo Bonzini
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY Dimitris Aragiorgis
2015-05-11 10:19 ` Kevin Wolf
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 5/5] raw-posix: Introduce hdev_is_sg() Dimitris Aragiorgis
2015-05-10 14:04 ` [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550DE46.8090907@redhat.com \
--to=eblake@redhat.com \
--cc=dimara@arrikto.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.