From: Olaf Hering <olaf@aepfle.de>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Remove CPPFLAGS_XEN
Date: Mon, 11 May 2015 13:30:13 +0200 [thread overview]
Message-ID: <20150511113013.GA19976@aepfle.de> (raw)
In-Reply-To: <CAEaD8JOnsPNNXnoifP-+yxePASOLYn7NNXF5dapcU9_C5Dc2Zw@mail.gmail.com>
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:
> What is the problem you're trying to solve? We shouldn't require user to pass
> additional parameters for common cases of we can avoid it
My xen headers are in /odd/path, so I first tried
env CPPFLAGS_XEN=/odd/path/include ./configure && make
This failed because CPPFLAGS_XEN is a private make variable. Later I
looked at ./configure --help and noticed the CPPFLAGS variable, wich is
aoppearently the prefered way to specify them.
And the common case is maybe that /usr/include already has the xen
headers, in which case CPPFLAGS_XEN is not needed. I assume the initial
change should have done what my patch does.
Olaf
next prev parent reply other threads:[~2015-05-11 11:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 11:13 [PATCH] Remove CPPFLAGS_XEN Olaf Hering
2015-05-11 11:24 ` Vladimir 'phcoder' Serbinenko
2015-05-11 11:30 ` Olaf Hering [this message]
2015-05-11 11:33 ` Vladimir 'phcoder' Serbinenko
2015-05-11 11:36 ` Olaf Hering
2015-05-13 10:31 ` Olaf Hering
2015-05-13 15:30 ` Olaf Hering
2015-05-13 17:27 ` Andrei Borzenkov
2015-05-11 11:28 ` Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511113013.GA19976@aepfle.de \
--to=olaf@aepfle.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.