All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Welling <mwelling@ieee.org>
To: Nishanth Menon <nm@ti.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-next <linux-next@vger.kernel.org>,
	linux-spi@vger.kernel.org
Subject: Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot
Date: Mon, 11 May 2015 13:54:51 -0500	[thread overview]
Message-ID: <20150511185451.GA16240@deathray> (raw)
In-Reply-To: <5550F47C.1030902@ti.com>

On Mon, May 11, 2015 at 01:27:08PM -0500, Nishanth Menon wrote:
> On 05/11/2015 12:07 PM, Michael Welling wrote:
> > On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote:
> >> Hi,
> >>
> >> SDP4430 uses a SPI based network chip ks8851.
> >>
> >> next-20150508:
> >> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt
> >>
> >> However, next-20150511:
> >> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt
> >>
> > 
> > I will look into this but it is going to be difficult to debug with access to the hardware.
> > This is what I get for changing a driver that effects so many SoCs.
> > 
> 
> Let me know if there is any test patch you'd want me to run. The board
> is on a remote "board farm" which most of TI folks have access to as
> well.. So, if you need anything run, just send out a debug patch OR a
> potential fix and we can help try it out and provide logs back for
> your debug.
>

So it appears that I have broken the native chip select support.

I have a serial flash at spi0cs0 and if I use the GPIO for chip select
it detects:
m25p80 spi1.0: n25q128a13 (16384 Kbytes)

If I use the native chip select it does not:
m25p80 spi1.0: unrecognized JEDEC id bytes: ff, ff, ff

This allows me to find the issue and provide a follow up patch.
I will provide it when I have it ready to see if it fixes your issue.

If I cannot find a fix, we may have to revert these changes.

> 
> -- 
> Regards,
> Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: mwelling@ieee.org (Michael Welling)
To: linux-arm-kernel@lists.infradead.org
Subject: next-20150511 / omap2-mcspi: regression for sdp4430 boot
Date: Mon, 11 May 2015 13:54:51 -0500	[thread overview]
Message-ID: <20150511185451.GA16240@deathray> (raw)
In-Reply-To: <5550F47C.1030902@ti.com>

On Mon, May 11, 2015 at 01:27:08PM -0500, Nishanth Menon wrote:
> On 05/11/2015 12:07 PM, Michael Welling wrote:
> > On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote:
> >> Hi,
> >>
> >> SDP4430 uses a SPI based network chip ks8851.
> >>
> >> next-20150508:
> >> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt
> >>
> >> However, next-20150511:
> >> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt
> >>
> > 
> > I will look into this but it is going to be difficult to debug with access to the hardware.
> > This is what I get for changing a driver that effects so many SoCs.
> > 
> 
> Let me know if there is any test patch you'd want me to run. The board
> is on a remote "board farm" which most of TI folks have access to as
> well.. So, if you need anything run, just send out a debug patch OR a
> potential fix and we can help try it out and provide logs back for
> your debug.
>

So it appears that I have broken the native chip select support.

I have a serial flash at spi0cs0 and if I use the GPIO for chip select
it detects:
m25p80 spi1.0: n25q128a13 (16384 Kbytes)

If I use the native chip select it does not:
m25p80 spi1.0: unrecognized JEDEC id bytes: ff, ff, ff

This allows me to find the issue and provide a follow up patch.
I will provide it when I have it ready to see if it fixes your issue.

If I cannot find a fix, we may have to revert these changes.

> 
> -- 
> Regards,
> Nishanth Menon

  parent reply	other threads:[~2015-05-11 18:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 16:50 next-20150511 / omap2-mcspi: regression for sdp4430 boot Nishanth Menon
2015-05-11 16:50 ` Nishanth Menon
2015-05-11 16:50 ` Nishanth Menon
2015-05-11 17:07 ` Michael Welling
2015-05-11 17:07   ` Michael Welling
2015-05-11 18:27   ` Nishanth Menon
2015-05-11 18:27     ` Nishanth Menon
2015-05-11 18:27     ` Nishanth Menon
     [not found]     ` <5550F47C.1030902-l0cyMroinI0@public.gmane.org>
2015-05-11 18:30       ` Michael Welling
2015-05-11 18:30         ` Michael Welling
2015-05-11 19:00         ` Nishanth Menon
2015-05-11 19:00           ` Nishanth Menon
2015-05-11 20:16           ` Michael Welling
2015-05-11 20:16             ` Michael Welling
2015-05-12 17:18             ` Nishanth Menon
2015-05-12 17:18               ` Nishanth Menon
2015-05-12 17:18               ` Nishanth Menon
2015-05-12 17:22               ` Michael Welling
2015-05-12 17:22                 ` Michael Welling
2015-05-12 17:28                 ` Nishanth Menon
2015-05-12 17:28                   ` Nishanth Menon
2015-05-12 17:28                   ` Nishanth Menon
2015-05-11 18:54     ` Michael Welling [this message]
2015-05-11 18:54       ` Michael Welling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511185451.GA16240@deathray \
    --to=mwelling@ieee.org \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.