From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v3 1/7] bio: Introduce LightNVM payload
Date: Tue, 12 May 2015 00:21:53 -0700 [thread overview]
Message-ID: <20150512072153.GA25438@infradead.org> (raw)
In-Reply-To: <5550997B.1000609@bjorling.me>
On Mon, May 11, 2015@01:58:51PM +0200, Matias Bj?rling wrote:
> >Can you explain why this needs to be done on a per-bio instead of a
> >per-request level? I don't really think a low-level driver should add
> >fields to struct bio as that can be easily remapped.
>
> When a bio is submitted through the block layer, it can be merged/splitted
> on going through the block layer. Thus, we don't know the number of physical
> addresses that must be mapped before its on the other side.
For any sort of passthrough bios that should not be the case. It's not
for BLOCK_PC, it's not for my new pass through NVMe commands and I don't
think it should be in this case.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Matias Bj?rling <m@bjorling.me>
Cc: Christoph Hellwig <hch@infradead.org>,
axboe@fb.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
keith.busch@intel.com, javier@paletta.io
Subject: Re: [PATCH v3 1/7] bio: Introduce LightNVM payload
Date: Tue, 12 May 2015 00:21:53 -0700 [thread overview]
Message-ID: <20150512072153.GA25438@infradead.org> (raw)
In-Reply-To: <5550997B.1000609@bjorling.me>
On Mon, May 11, 2015 at 01:58:51PM +0200, Matias Bj?rling wrote:
> >Can you explain why this needs to be done on a per-bio instead of a
> >per-request level? I don't really think a low-level driver should add
> >fields to struct bio as that can be easily remapped.
>
> When a bio is submitted through the block layer, it can be merged/splitted
> on going through the block layer. Thus, we don't know the number of physical
> addresses that must be mapped before its on the other side.
For any sort of passthrough bios that should not be the case. It's not
for BLOCK_PC, it's not for my new pass through NVMe commands and I don't
think it should be in this case.
next prev parent reply other threads:[~2015-05-12 7:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 14:26 [PATCH v3 0/7] Support for Open-Channel SSDs Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-04-22 14:26 ` [PATCH v3 1/7] bio: Introduce LightNVM payload Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-05-09 16:00 ` Christoph Hellwig
2015-05-09 16:00 ` Christoph Hellwig
2015-05-11 11:58 ` Matias Bjørling
2015-05-11 11:58 ` Matias Bjørling
2015-05-12 7:21 ` Christoph Hellwig [this message]
2015-05-12 7:21 ` Christoph Hellwig
2015-04-22 14:26 ` [PATCH v3 2/7] block: add REQ_NVM_GC for targets gc Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-05-09 16:00 ` Christoph Hellwig
2015-05-09 16:00 ` Christoph Hellwig
2015-04-22 14:26 ` [PATCH v3 3/7] lightnvm: Support for Open-Channel SSDs Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-04-22 14:26 ` [PATCH v3 4/7] lightnvm: RRPC target Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-04-22 14:26 ` [PATCH v3 5/7] null_blk: LightNVM support Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-04-22 14:26 ` [PATCH v3 6/7] nvme: rename and expose nvme_alloc_iod Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-04-22 14:26 ` [PATCH v3 7/7] nvme: LightNVM support Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-04-22 14:26 ` Matias Bjørling
2015-05-05 18:51 ` Matias Bjorling
2015-05-05 18:51 ` Matias Bjorling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512072153.GA25438@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.