Re: f2fs crypto: filename encryption facilities

Re: f2fs crypto: filename encryption facilities

[Dan Carpenter]

Hello Jaegeuk Kim,

The patch c54316510133: "f2fs crypto: filename encryption facilities"
from Apr 26, 2015, leads to the following static checker warning:

	fs/f2fs/crypto_fname.c:189 f2fs_fname_decrypt()
	warn: passing __func__ while the format string already contains the name of the function 'f2fs_fname_decrypt'

fs/f2fs/crypto_fname.c
   187          ablkcipher_request_free(req);
   188          if (res < 0) {
   189                  printk_ratelimited(KERN_ERR
   190                          "%s: Error in f2fs_fname_decrypt (error code %d)\n",
                                              ^^^^^^^^^^^^^^^^^^
   191                          __func__, res);
                                ^^^^^^^^

   192                  return res;
   193          }

regards,
dan carpenter

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y

Re: f2fs crypto: filename encryption facilities

[Jaegeuk Kim]

Hi Dan,

On Tue, May 12, 2015 at 02:38:57PM +0300, Dan Carpenter wrote:
> Hello Jaegeuk Kim,
> 
> The patch c54316510133: "f2fs crypto: filename encryption facilities"
> from Apr 26, 2015, leads to the following static checker warning:
> 
> 	fs/f2fs/crypto_fname.c:189 f2fs_fname_decrypt()
> 	warn: passing __func__ while the format string already contains the name of the function 'f2fs_fname_decrypt'

Let me remain this.
Since I'd like to merge these crypto files with ext4's ones and move into fs/.
It needs to sync between ext4 and f2fs.

Thanks,

> 
> fs/f2fs/crypto_fname.c
>    187          ablkcipher_request_free(req);
>    188          if (res < 0) {
>    189                  printk_ratelimited(KERN_ERR
>    190                          "%s: Error in f2fs_fname_decrypt (error code %d)\n",
>                                               ^^^^^^^^^^^^^^^^^^
>    191                          __func__, res);
>                                 ^^^^^^^^
> 
>    192                  return res;
>    193          }
> 
> regards,
> dan carpenter

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y