From: Dominick Grift <dac.override@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4
Date: Tue, 12 May 2015 20:27:42 +0200 [thread overview]
Message-ID: <20150512182741.GD9693@x131e> (raw)
In-Reply-To: <1431355986.566.18.camel@edumazet-glaptop2.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On Mon, May 11, 2015 at 07:53:06AM -0700, Eric Dumazet wrote:
>
> Hi Dominick
>
> Have you tried this patch I sent last monday ?
>
> I will submit formally when I get a test result.
>
> Thanks
Eric,
I have tested the below patch and everything is in order!
Thank you!
>
> diff --git a/net/bridge/br_stp_timer.c b/net/bridge/br_stp_timer.c
> index 4fcaa67750fda845ad0a180332c4cd96a9524086..7caf7fae2d5b8aa369b924e1c87a47c343fb8954 100644
> --- a/net/bridge/br_stp_timer.c
> +++ b/net/bridge/br_stp_timer.c
> @@ -97,7 +97,9 @@ static void br_forward_delay_timer_expired(unsigned long arg)
> netif_carrier_on(br->dev);
> }
> br_log_state(p);
> + rcu_read_lock();
> br_ifinfo_notify(RTM_NEWLINK, p);
> + rcu_read_unlock();
> spin_unlock(&br->lock);
> }
>
>
>
--
02DFF788
4D30 903A 1CF3 B756 FB48 1514 3148 83A2 02DF F788
http://keys.gnupg.net/pks/lookup?op=vindex&search=0x314883A202DFF788
Dominick Grift
[-- Attachment #2: Type: application/pgp-signature, Size: 648 bytes --]
next prev parent reply other threads:[~2015-05-12 18:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 17:07 [Bridge] Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4 Josh Boyer
2015-04-23 17:07 ` Josh Boyer
2015-04-23 17:35 ` [Bridge] " Sudeep Holla
2015-04-23 17:35 ` Sudeep Holla
2015-04-23 22:53 ` [Bridge] " Cong Wang
2015-04-23 22:53 ` Cong Wang
2015-05-04 13:39 ` Dominick Grift
2015-05-04 18:45 ` Cong Wang
2015-05-04 20:27 ` Stephen Hemminger
2015-05-04 21:35 ` Cong Wang
2015-05-11 13:15 ` Dominick Grift
2015-05-11 14:53 ` Eric Dumazet
2015-05-11 17:42 ` Dominick Grift
2015-05-12 0:13 ` poma
2015-05-12 0:37 ` Eric Dumazet
2015-05-12 1:33 ` poma
2015-05-12 18:27 ` Dominick Grift [this message]
2015-05-21 19:22 ` Josh Boyer
2015-05-21 20:06 ` Eric Dumazet
2015-05-05 2:32 ` Vlad Yasevich
2015-05-04 20:49 ` Eric Dumazet
2015-05-04 21:38 ` Cong Wang
2015-05-04 22:06 ` Eric Dumazet
2015-05-04 22:17 ` Cong Wang
2015-05-04 22:29 ` Eric Dumazet
2015-05-04 22:44 ` Cong Wang
2015-05-04 23:00 ` Eric Dumazet
2015-05-04 23:22 ` David Miller
2015-05-05 8:33 ` Dominick Grift
2015-05-21 20:28 ` [PATCH net] bridge: fix lockdep splat Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512182741.GD9693@x131e \
--to=dac.override@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.