All of lore.kernel.org
 help / color / mirror / Atom feed
From: josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Linus Torvalds
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCHv2 1/2] clone: Support passing tls argument via C rather than pt_regs magic
Date: Tue, 12 May 2015 17:53:37 -0700	[thread overview]
Message-ID: <20150513005337.GB14292@cloud> (raw)
In-Reply-To: <20150512142250.dcb053da81855ae1b5861173-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>

On Tue, May 12, 2015 at 02:22:50PM -0700, Andrew Morton wrote:
> On Mon, 11 May 2015 12:29:19 -0700 Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org> wrote:
> 
> > Introduce a new CONFIG_HAVE_COPY_THREAD_TLS for architectures to opt
> > into, and a new copy_thread_tls that accepts the tls parameter as an
> > additional unsigned long (syscall-argument-sized) argument.
> > Change sys_clone's tls argument to an unsigned long (which does
> > not change the ABI), and pass that down to copy_thread_tls.
> > 
> > Architectures that don't opt into copy_thread_tls will continue to
> > ignore the C argument to sys_clone in favor of the pt_regs captured at
> > kernel entry, and thus will be unable to introduce new versions of the
> > clone syscall.
> 
> What happens quite frequently is that we do something for x86 with the
> expectation that other architectures will follow along, but this
> doesn't happen.  The arch maintainers simply didn't know about it or
> nobody nags them.  Nothing happens and inconsistencies hang around for
> years.  eg, http://lkml.iu.edu/hypermail/linux/kernel/1504.2/04993.html

In this case, there will be a very clear incentive to switch to
CONFIG_HAVE_COPY_THREAD_TLS: if you don't, you can't enable new
syscalls.

- Josh Triplett

WARNING: multiple messages have this Message-ID (diff)
From: josh@joshtriplett.org
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [PATCHv2 1/2] clone: Support passing tls argument via C rather than pt_regs magic
Date: Tue, 12 May 2015 17:53:37 -0700	[thread overview]
Message-ID: <20150513005337.GB14292@cloud> (raw)
In-Reply-To: <20150512142250.dcb053da81855ae1b5861173@linux-foundation.org>

On Tue, May 12, 2015 at 02:22:50PM -0700, Andrew Morton wrote:
> On Mon, 11 May 2015 12:29:19 -0700 Josh Triplett <josh@joshtriplett.org> wrote:
> 
> > Introduce a new CONFIG_HAVE_COPY_THREAD_TLS for architectures to opt
> > into, and a new copy_thread_tls that accepts the tls parameter as an
> > additional unsigned long (syscall-argument-sized) argument.
> > Change sys_clone's tls argument to an unsigned long (which does
> > not change the ABI), and pass that down to copy_thread_tls.
> > 
> > Architectures that don't opt into copy_thread_tls will continue to
> > ignore the C argument to sys_clone in favor of the pt_regs captured at
> > kernel entry, and thus will be unable to introduce new versions of the
> > clone syscall.
> 
> What happens quite frequently is that we do something for x86 with the
> expectation that other architectures will follow along, but this
> doesn't happen.  The arch maintainers simply didn't know about it or
> nobody nags them.  Nothing happens and inconsistencies hang around for
> years.  eg, http://lkml.iu.edu/hypermail/linux/kernel/1504.2/04993.html

In this case, there will be a very clear incentive to switch to
CONFIG_HAVE_COPY_THREAD_TLS: if you don't, you can't enable new
syscalls.

- Josh Triplett

  parent reply	other threads:[~2015-05-13  0:53 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 19:29 [PATCHv2 1/2] clone: Support passing tls argument via C rather than pt_regs magic Josh Triplett
2015-05-11 19:29 ` Josh Triplett
2015-05-12 21:22 ` Andrew Morton
2015-05-12 21:38   ` Peter Zijlstra
     [not found]     ` <20150512213843.GV21418-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2015-05-12 21:49       ` Andrew Morton
2015-05-12 21:49         ` Andrew Morton
     [not found]         ` <20150512144910.0b49c9a7a13336773449db33-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-05-13  8:34           ` [RFC PATCH] Documentation/arch: Add Documentation/arch-TODO Ingo Molnar
2015-05-13  8:34             ` Ingo Molnar
2015-05-13  8:34             ` Ingo Molnar
2015-05-13  8:34             ` Ingo Molnar
2015-05-13  8:56             ` [RFC PATCH v2] " Ingo Molnar
2015-05-13  8:56               ` Ingo Molnar
2015-05-13  8:56               ` Ingo Molnar
     [not found]               ` <20150513085636.GA11030-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-13  9:24                 ` [RFC PATCH v3] " Ingo Molnar
2015-05-13  9:24                   ` Ingo Molnar
2015-05-13  9:24                   ` Ingo Molnar
2015-05-13  9:24                   ` Ingo Molnar
2015-05-13  9:46                   ` Ingo Molnar
2015-05-13  9:46                     ` Ingo Molnar
2015-05-13  9:46                     ` Ingo Molnar
     [not found]                     ` <20150513094622.GC11030-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-13  9:47                       ` [RFC PATCH v5] " Ingo Molnar
2015-05-13  9:47                         ` Ingo Molnar
2015-05-13  9:47                         ` Ingo Molnar
2015-05-13  9:47                         ` Ingo Molnar
2015-05-13 13:18                         ` Borislav Petkov
     [not found]                           ` <20150513131835.GJ1517-fF5Pk5pvG8Y@public.gmane.org>
2015-05-13 13:48                             ` [RFC PATCH v6] Documentation/arch: Add Documentation/arch-features.txt Ingo Molnar
2015-05-13 13:48                               ` Ingo Molnar
2015-05-13 13:48                               ` Ingo Molnar
2015-05-13 13:48                               ` Ingo Molnar
2015-05-13 16:27                               ` Josh Triplett
2015-05-13 16:53                                 ` Josh Triplett
2015-05-13 16:53                                   ` Josh Triplett
2015-05-14 10:16                                   ` Ingo Molnar
     [not found]                                     ` <20150514101615.GB27550-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-14 10:31                                       ` Josh Triplett
2015-05-14 10:31                                         ` Josh Triplett
2015-05-13 22:05                                 ` Andrew Morton
2015-05-13 22:05                                   ` Andrew Morton
     [not found]                                   ` <20150513150523.ddd65d7cd51f820b78f0c8e3-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-05-14 10:02                                     ` Ingo Molnar
2015-05-14 10:02                                       ` Ingo Molnar
2015-05-14 10:15                                     ` [PATCH] Documentation/arch: Add kernel feature descriptions and arch support status under Documentation/features/ Ingo Molnar
2015-05-14 10:15                                       ` Ingo Molnar
     [not found]                                       ` <20150514101518.GA27550-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-14 10:35                                         ` [PATCH v2] " Ingo Molnar
2015-05-14 10:35                                           ` Ingo Molnar
2015-05-14 19:38                                           ` Andrew Morton
2015-05-14 19:59                                             ` Ingo Molnar
     [not found]                                               ` <20150514195925.GA27570-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-14 22:33                                                 ` Stephen Rothwell
2015-05-14 22:33                                                   ` Stephen Rothwell
     [not found]                                                   ` <20150515083334.535ad43e-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2015-05-15  7:38                                                     ` Ingo Molnar
2015-05-15  7:38                                                       ` Ingo Molnar
     [not found]                                                       ` <20150515073805.GA14993-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-15  7:51                                                         ` Ingo Molnar
2015-05-15  7:51                                                           ` Ingo Molnar
2015-05-15  9:37                                               ` Ingo Molnar
     [not found]                                             ` <20150514123835.1bf436bc35d711f8dbf9bc0f-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-05-14 20:34                                               ` Richard Weinberger
2015-05-14 20:34                                                 ` Richard Weinberger
2015-05-14 22:57                                               ` Michael Ellerman
2015-05-14 22:57                                                 ` Michael Ellerman
     [not found]                                                 ` <1431644248.2981.1.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-05-15  7:49                                                   ` Ingo Molnar
2015-05-15  7:49                                                     ` Ingo Molnar
2015-05-18  1:37                                                     ` Michael Ellerman
     [not found]                                                       ` <1431913033.13218.2.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-05-18  8:54                                                         ` Ingo Molnar
2015-05-18  8:54                                                           ` Ingo Molnar
     [not found]                                                           ` <20150518085423.GA24944-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-19  2:02                                                             ` Michael Ellerman
2015-05-19  2:02                                                               ` Michael Ellerman
     [not found]                                           ` <20150514103544.GA7027-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-22 15:49                                             ` Jonathan Corbet
2015-05-22 15:49                                               ` Jonathan Corbet
     [not found]                                               ` <20150522094931.78a43421-T1hC0tSOHrs@public.gmane.org>
2015-05-23  8:07                                                 ` Ingo Molnar
2015-05-23  8:07                                                   ` Ingo Molnar
2015-05-24 18:44                                                   ` Jonathan Corbet
     [not found]                                                     ` <20150524124447.0c395540-T1hC0tSOHrs@public.gmane.org>
2015-06-03 11:03                                                       ` [GIT PULL] Documentation/features: Add kernel feature descriptions and arch support status files " Ingo Molnar
2015-06-03 11:03                                                         ` Ingo Molnar
     [not found]                                                         ` <20150603110355.GA12079-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-08 23:08                                                           ` Jonathan Corbet
2015-06-08 23:08                                                             ` Jonathan Corbet
2015-05-14  7:08                                 ` [RFC PATCH v6] Documentation/arch: Add Documentation/arch-features.txt Ingo Molnar
2015-05-14  3:55                               ` Paul Mackerras
2015-05-14  7:02                                 ` Ingo Molnar
     [not found]                         ` <20150513094756.GD11030-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-13 14:09                           ` [RFC PATCH v5] Documentation/arch: Add Documentation/arch-TODO Michele Curti
2015-05-13 14:09                             ` Michele Curti
2015-05-13 14:42                             ` Geert Uytterhoeven
     [not found]                               ` <CAMuHMdXV68nie93Rb=Z+vYtn2aNex=s5E4+Z=QGojF+8EbPbKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-14  7:21                                 ` H. Peter Anvin
2015-05-14  7:21                                   ` H. Peter Anvin
2015-05-14  7:21                               ` H. Peter Anvin
     [not found]   ` <20150512142250.dcb053da81855ae1b5861173-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-05-13  0:53     ` josh-iaAMLnmF4UmaiuxdJuQwMA [this message]
2015-05-13  0:53       ` [PATCHv2 1/2] clone: Support passing tls argument via C rather than pt_regs magic josh
2015-05-13 22:56 ` Andrew Morton
2015-05-13 22:56   ` Andrew Morton
     [not found]   ` <20150513155628.65dc253bea9485cb7910678b-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-05-13 23:25     ` josh-iaAMLnmF4UmaiuxdJuQwMA
2015-05-13 23:25       ` josh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150513005337.GB14292@cloud \
    --to=josh-iaamlnmf4umaiuxdjuqwma@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.