From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: josh@joshtriplett.org
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com,
fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com
Subject: Re: [PATCH tip/core/rcu 2/3] rcutorture: Test both RCU-sched and RCU-bh for Tiny RCU
Date: Wed, 13 May 2015 06:07:28 -0700 [thread overview]
Message-ID: <20150513130728.GX6776@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150513005929.GE14292@cloud>
On Tue, May 12, 2015 at 05:59:29PM -0700, josh@joshtriplett.org wrote:
> On Tue, May 12, 2015 at 03:49:12PM -0700, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> >
> > Reported-by: "Ahmed, Iftekhar" <ahmedi@onid.oregonstate.edu>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Could you elaborate a bit more on this patch (ideally in its commit
> message)? I see an addition of a command-line parameter to test rcu_bh;
> is rcu-sched already tested elsewhere by some other config, or does this
> parameter somehow enable testing both?
The commit log now reads as follows, does that help?
Thanx, Paul
------------------------------------------------------------------------
rcutorture: Test both RCU-sched and RCU-bh for Tiny RCU
Tiny RCU supports both RCU-sched and RCU-bh, but only RCU-sched is
currently tested by the rcutorture scripts. This commit therefore
changes the TINY02 configuration to test RCU-bh, with TINY01 continuing
to test RCU-sched.
This shortcoming of the current rcutorture tests was located by mutation
testing by Iftekhar. The idea behind mutation testing is to automatically
mutate the code under test. If a given mutant is not caught by testing,
this is a hint that the testing might need to be improved, as was the
case here. Note that this is only a hint because it is possible to mutate
the code into something else that still works. For example, a mutation
that removes (say) a WARN_ON() will not normally result in a test failure.
This change resulted in the test failure caused by list mishandling,
which is fixed by the next commit.
Reported-by: "Ahmed, Iftekhar" <ahmedi@onid.oregonstate.edu>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
next prev parent reply other threads:[~2015-05-13 13:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 22:48 [PATCH tip/core/rcu 0/3] Tiny RCU updates for 4.2 Paul E. McKenney
2015-05-12 22:49 ` [PATCH tip/core/rcu 1/3] rcu: Further shrink Tiny RCU by making empty functions static inlines Paul E. McKenney
2015-05-12 22:49 ` [PATCH tip/core/rcu 2/3] rcutorture: Test both RCU-sched and RCU-bh for Tiny RCU Paul E. McKenney
2015-05-13 0:59 ` josh
2015-05-13 13:03 ` Steven Rostedt
2015-05-13 13:07 ` Paul E. McKenney [this message]
2015-05-13 16:32 ` Josh Triplett
2015-05-12 22:49 ` [PATCH tip/core/rcu 3/3] rcu: Correctly handle non-empty Tiny RCU callback list with none ready Paul E. McKenney
2015-05-13 0:58 ` josh
2015-05-13 13:09 ` Paul E. McKenney
2015-05-13 0:57 ` [PATCH tip/core/rcu 1/3] rcu: Further shrink Tiny RCU by making empty functions static inlines josh
2015-05-13 12:59 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513130728.GX6776@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.