* [PATCH] ASoC: rt5645: Rename HP control to Headphone
@ 2015-05-13 8:15 Nicolas Boichat
2015-05-13 11:59 ` Bard Liao
2015-05-14 0:43 ` Nicolas Boichat
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Boichat @ 2015-05-13 8:15 UTC (permalink / raw)
To: alsa-devel; +Cc: Oder Chiou, Bard Liao, Koro Chen
Use the standard name "Headphone" instead of "HP" for better
userspace integration.
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---
sound/soc/codecs/rt5645.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index be4d741..bc925f0 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -464,9 +464,9 @@ static const struct snd_kcontrol_new rt5645_snd_controls[] = {
RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* Headphone Output Volume */
- SOC_DOUBLE("HP Channel Switch", RT5645_HP_VOL,
+ SOC_DOUBLE("Headphone Channel Switch", RT5645_HP_VOL,
RT5645_VOL_L_SFT, RT5645_VOL_R_SFT, 1, 1),
- SOC_DOUBLE_TLV("HP Playback Volume", RT5645_HP_VOL,
+ SOC_DOUBLE_TLV("Headphone Playback Volume", RT5645_HP_VOL,
RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* OUTPUT Control */
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: rt5645: Rename HP control to Headphone
2015-05-13 8:15 [PATCH] ASoC: rt5645: Rename HP control to Headphone Nicolas Boichat
@ 2015-05-13 11:59 ` Bard Liao
2015-05-13 14:45 ` Charles Keepax
2015-05-14 0:43 ` Nicolas Boichat
1 sibling, 1 reply; 5+ messages in thread
From: Bard Liao @ 2015-05-13 11:59 UTC (permalink / raw)
To: Nicolas Boichat, alsa-devel@alsa-project.org; +Cc: Oder Chiou, Koro Chen
> -----Original Message-----
> From: Nicolas Boichat [mailto:drinkcat@chromium.org]
> Sent: Wednesday, May 13, 2015 4:15 PM
> To: alsa-devel@alsa-project.org
> Cc: Bard Liao; Oder Chiou; Koro Chen
> Subject: [PATCH] ASoC: rt5645: Rename HP control to Headphone
>
> Use the standard name "Headphone" instead of "HP" for better userspace
> integration.
>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Acked-by: Bard Liao <bardliao@realtek.com>
Should we send it to Mark Brown <broonie@kernel.org>?
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: rt5645: Rename HP control to Headphone
2015-05-13 11:59 ` Bard Liao
@ 2015-05-13 14:45 ` Charles Keepax
0 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2015-05-13 14:45 UTC (permalink / raw)
To: Bard Liao
Cc: Oder Chiou, alsa-devel@alsa-project.org, Nicolas Boichat,
Koro Chen
On Wed, May 13, 2015 at 11:59:43AM +0000, Bard Liao wrote:
> > -----Original Message-----
> > From: Nicolas Boichat [mailto:drinkcat@chromium.org]
> > Sent: Wednesday, May 13, 2015 4:15 PM
> > To: alsa-devel@alsa-project.org
> > Cc: Bard Liao; Oder Chiou; Koro Chen
> > Subject: [PATCH] ASoC: rt5645: Rename HP control to Headphone
> >
> > Use the standard name "Headphone" instead of "HP" for better userspace
> > integration.
> >
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>
> Acked-by: Bard Liao <bardliao@realtek.com>
>
> Should we send it to Mark Brown <broonie@kernel.org>?
Yes, he is the maintainer that would apply it so the patch needs
to be sent to him.
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ASoC: rt5645: Rename HP control to Headphone
2015-05-13 8:15 [PATCH] ASoC: rt5645: Rename HP control to Headphone Nicolas Boichat
2015-05-13 11:59 ` Bard Liao
@ 2015-05-14 0:43 ` Nicolas Boichat
2015-05-19 12:11 ` Mark Brown
1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Boichat @ 2015-05-14 0:43 UTC (permalink / raw)
To: Mark Brown
Cc: Oder Chiou, alsa-devel, Nicolas Boichat, Koro Chen, Bard Liao,
Charles Keepax
Use the standard name "Headphone" instead of "HP" for better
userspace integration.
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Acked-by: Bard Liao <bardliao@realtek.com>
---
Resending without modification, adding Mark to CC list.
Thanks!
sound/soc/codecs/rt5645.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index be4d741..bc925f0 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -464,9 +464,9 @@ static const struct snd_kcontrol_new rt5645_snd_controls[] = {
RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* Headphone Output Volume */
- SOC_DOUBLE("HP Channel Switch", RT5645_HP_VOL,
+ SOC_DOUBLE("Headphone Channel Switch", RT5645_HP_VOL,
RT5645_VOL_L_SFT, RT5645_VOL_R_SFT, 1, 1),
- SOC_DOUBLE_TLV("HP Playback Volume", RT5645_HP_VOL,
+ SOC_DOUBLE_TLV("Headphone Playback Volume", RT5645_HP_VOL,
RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* OUTPUT Control */
--
2.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: rt5645: Rename HP control to Headphone
2015-05-14 0:43 ` Nicolas Boichat
@ 2015-05-19 12:11 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2015-05-19 12:11 UTC (permalink / raw)
To: Nicolas Boichat
Cc: Oder Chiou, Bard Liao, alsa-devel, Koro Chen, Charles Keepax
[-- Attachment #1.1: Type: text/plain, Size: 171 bytes --]
On Thu, May 14, 2015 at 08:43:31AM +0800, Nicolas Boichat wrote:
> Use the standard name "Headphone" instead of "HP" for better
> userspace integration.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-19 12:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-13 8:15 [PATCH] ASoC: rt5645: Rename HP control to Headphone Nicolas Boichat
2015-05-13 11:59 ` Bard Liao
2015-05-13 14:45 ` Charles Keepax
2015-05-14 0:43 ` Nicolas Boichat
2015-05-19 12:11 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.