From: Olaf Hering <olaf@aepfle.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v9 1/4] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc
Date: Wed, 13 May 2015 17:46:45 +0200 [thread overview]
Message-ID: <20150513154645.GA27391@aepfle.de> (raw)
In-Reply-To: <1431361890-3466-2-git-send-email-boris.ostrovsky@oracle.com>
On Mon, May 11, Boris Ostrovsky wrote:
> xc_cputopoinfo() is not expected to be used on a hot path and therefore
> hypercall buffer management can be pushed into libxc. This will simplify
> life for callers.
This got just merged and cause a compile error. Looks like gcc is right, if
xc_cputopoinfo fails the pointer will be uninitialized.
gcc -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD
-MF .xenpm.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O1 -Werror
-I/work/xen/xengit/xen-staging/tools/misc/../../tools
-I/work/xen/xengit/xen-staging/tools/misc/../../tools/libxc/include
-I/work/xen/xengit/xen-staging/tools/misc/../../tools/include
-I/work/xen/xengit/xen-staging/tools/misc/../../tools/include
-I/work/xen/xengit/xen-staging/tools/misc/../../tools/xenstore/include
-I/work/xen/xengit/xen-staging/tools/misc/../../tools/include -c -o
xenpm.o xenpm.c
cc1: warnings being treated as errors
xenpm.c: In function 'cpu_topology_func':
xenpm.c:963:19: error: 'cputopo' may be used uninitialized in this function
xenpm.c: In function 'signal_int_handler':
xenpm.c:358:19: error: 'cputopo' may be used uninitialized in this function
gmake[3]: *** [xenpm.o] Error 1
Olaf
next prev parent reply other threads:[~2015-05-13 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 16:31 [PATCH v9 0/4] Display IO topology when PXM data is available (plus some cleanup) Boris Ostrovsky
2015-05-11 16:31 ` [PATCH v9 1/4] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc Boris Ostrovsky
2015-05-13 15:46 ` Olaf Hering [this message]
2015-05-13 15:56 ` Boris Ostrovsky
2015-05-13 16:51 ` Olaf Hering
2015-05-11 16:31 ` [PATCH v9 2/4] libxl/libxc: Move libxl_get_numainfo()'s " Boris Ostrovsky
2015-05-11 16:31 ` [PATCH v9 3/4] libxc: Provide set_xen_guest_handle_offset macro Boris Ostrovsky
2015-05-13 14:56 ` Ian Campbell
2015-05-11 16:31 ` [PATCH v9 4/4] libxl: Add interface for querying hypervisor about PCI topology Boris Ostrovsky
2015-05-15 8:43 ` Olaf Hering
2015-05-15 13:21 ` Boris Ostrovsky
2015-05-15 13:50 ` Olaf Hering
2015-05-15 14:01 ` Boris Ostrovsky
2015-05-15 14:23 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513154645.GA27391@aepfle.de \
--to=olaf@aepfle.de \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.