Re: [PATCH v9 1/4] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 05/13/2015 11:46 AM, Olaf Hering wrote:
> On Mon, May 11, Boris Ostrovsky wrote:
>
>> xc_cputopoinfo() is not expected to be used on a hot path and therefore
>> hypercall buffer management can be pushed into libxc. This will simplify
>> life for callers.
> This got just merged and cause a compile error. Looks like gcc is right, if
> xc_cputopoinfo fails the pointer will be uninitialized.
>
> gcc  -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
> -Wstrict-prototypes -Wdeclaration-after-statement   -D__XEN_TOOLS__ -MMD
> -MF .xenpm.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -O1 -Werror
> -I/work/xen/xengit/xen-staging/tools/misc/../../tools
> -I/work/xen/xengit/xen-staging/tools/misc/../../tools/libxc/include
> -I/work/xen/xengit/xen-staging/tools/misc/../../tools/include
> -I/work/xen/xengit/xen-staging/tools/misc/../../tools/include
> -I/work/xen/xengit/xen-staging/tools/misc/../../tools/xenstore/include
> -I/work/xen/xengit/xen-staging/tools/misc/../../tools/include  -c -o
> xenpm.o xenpm.c
> cc1: warnings being treated as errors
> xenpm.c: In function 'cpu_topology_func':
> xenpm.c:963:19: error: 'cputopo' may be used uninitialized in this function
> xenpm.c: In function 'signal_int_handler':
> xenpm.c:358:19: error: 'cputopo' may be used uninitialized in this function
> gmake[3]: *** [xenpm.o] Error 1

Right.

I build debug version and it adds -O0 which apparently doesn't warn on 
this error.

Ian, do you want me to resubmit the series or send a fix for this?

-boris