From: Michal Kubecek <mkubecek@suse.cz>
To: roopa <roopa@cumulusnetworks.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net 1/2] ipv6: do not delete previously existing ECMP routes if add fails
Date: Wed, 13 May 2015 22:06:56 +0200 [thread overview]
Message-ID: <20150513200656.GA31076@unicorn.suse.cz> (raw)
In-Reply-To: <555351EC.9050805@cumulusnetworks.com>
On Wed, May 13, 2015 at 06:30:20AM -0700, roopa wrote:
> >
> This looks like a similar bug i was trying to fix some time back:
> http://patchwork.ozlabs.org/patch/362296/
>
> (I am not sure if my full patch is still valid. I was thinking of
> re-spining it sometime soon. If you are interested in trying it out,
> please do)
It's essentially the same idea but I prefer to use variable remaining
which is already there and is needed anyway rather than introduce
three extra variables for the cleanup (which is quite similar to the
suggestion from Hannes' reply).
I've sent v2 few minutes ago.
Michal Kubecek
next prev parent reply other threads:[~2015-05-13 20:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 9:50 [PATCH net 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-13 9:50 ` [PATCH net 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-13 12:28 ` Nicolas Dichtel
2015-05-13 12:49 ` Michal Kubecek
2015-05-13 13:30 ` roopa
2015-05-13 20:06 ` Michal Kubecek [this message]
2015-05-13 19:59 ` [PATCH net v2 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-13 19:59 ` [PATCH net v2 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-14 18:54 ` Nicolas Dichtel
2015-05-13 19:59 ` [PATCH net v2 2/2] ipv6: fix ECMP route replacement Michal Kubecek
2015-05-14 18:58 ` Nicolas Dichtel
2015-05-14 21:49 ` Michal Kubecek
2015-05-15 8:51 ` Michal Kubecek
2015-05-15 16:12 ` David Miller
2015-05-15 17:41 ` Michal Kubecek
2015-05-16 21:18 ` David Miller
2015-05-18 18:53 ` [PATCH net v3 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-18 18:53 ` [PATCH net v3 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-18 18:54 ` [PATCH net v3 2/2] ipv6: fix ECMP route replacement Michal Kubecek
2015-05-19 20:51 ` David Miller
2015-05-20 8:56 ` Nicolas Dichtel
2015-05-20 16:03 ` [PATCH net v3 0/2] IPv6 ECMP route add/replace fixes David Miller
2015-05-13 9:50 ` [PATCH net 2/2] ipv6: fix ECMP route replacement Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513200656.GA31076@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=roopa@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.