From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Michal Kubecek <mkubecek@suse.cz>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
roopa <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net v2 1/2] ipv6: do not delete previously existing ECMP routes if add fails
Date: Thu, 14 May 2015 20:54:05 +0200 [thread overview]
Message-ID: <5554EF4D.9030803@6wind.com> (raw)
In-Reply-To: <bb3d4b3ef28339bbf863a42e569bbdc1078565ee.1431546602.git.mkubecek@suse.cz>
Le 13/05/2015 21:59, Michal Kubecek a écrit :
> If adding a nexthop of an IPv6 multipath route fails, comment in
> ip6_route_multipath() says we are going to delete all nexthops already
> added. However, current implementation deletes even the routes it
> hasn't even tried to add yet. For example, running
>
> ip route add 1234:5678::/64 \
> nexthop via fe80::aa dev dummy1 \
> nexthop via fe80::bb dev dummy1 \
> nexthop via fe80::cc dev dummy1
>
> twice results in removing all routes first command added.
>
> Limit the second (delete) run to nexthops that succeeded in the first
> (add) run.
>
> Fixes: 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2015-05-14 18:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 9:50 [PATCH net 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-13 9:50 ` [PATCH net 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-13 12:28 ` Nicolas Dichtel
2015-05-13 12:49 ` Michal Kubecek
2015-05-13 13:30 ` roopa
2015-05-13 20:06 ` Michal Kubecek
2015-05-13 19:59 ` [PATCH net v2 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-13 19:59 ` [PATCH net v2 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-14 18:54 ` Nicolas Dichtel [this message]
2015-05-13 19:59 ` [PATCH net v2 2/2] ipv6: fix ECMP route replacement Michal Kubecek
2015-05-14 18:58 ` Nicolas Dichtel
2015-05-14 21:49 ` Michal Kubecek
2015-05-15 8:51 ` Michal Kubecek
2015-05-15 16:12 ` David Miller
2015-05-15 17:41 ` Michal Kubecek
2015-05-16 21:18 ` David Miller
2015-05-18 18:53 ` [PATCH net v3 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-18 18:53 ` [PATCH net v3 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-18 18:54 ` [PATCH net v3 2/2] ipv6: fix ECMP route replacement Michal Kubecek
2015-05-19 20:51 ` David Miller
2015-05-20 8:56 ` Nicolas Dichtel
2015-05-20 16:03 ` [PATCH net v3 0/2] IPv6 ECMP route add/replace fixes David Miller
2015-05-13 9:50 ` [PATCH net 2/2] ipv6: fix ECMP route replacement Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554EF4D.9030803@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.