From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: flow_dissect: use programable dissector in skb_flow_dissect and friends
Date: Fri, 15 May 2015 09:54:31 +0000 [thread overview]
Message-ID: <20150515095431.GA24328@mwanda> (raw)
Hello Jiri Pirko,
The patch 06635a35d13d: "flow_dissect: use programable dissector in
skb_flow_dissect and friends" from May 12, 2015, leads to the
following static checker warning:
net/core/flow_dissector.c:283 __skb_flow_dissect()
info: ignoring unreachable code.
net/core/flow_dissector.c
279
280 if (skb_flow_dissector_uses_key(flow_dissector,
281 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS)) {
282 return true;
^^^^^^^^^^^^
283 key_addrs = skb_flow_dissector_target(flow_dissector,
284 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
285 target_container);
286 key_addrs->src = hdr->srcnode;
287 key_addrs->dst = 0;
288 }
289 return true;
regards,
dan carpenter
next reply other threads:[~2015-05-15 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 9:54 Dan Carpenter [this message]
2015-05-15 10:30 ` flow_dissect: use programable dissector in skb_flow_dissect and friends Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515095431.GA24328@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.