* re: flow_dissect: use programable dissector in skb_flow_dissect and friends
@ 2015-05-15 9:54 Dan Carpenter
2015-05-15 10:30 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-05-15 9:54 UTC (permalink / raw)
To: kernel-janitors
Hello Jiri Pirko,
The patch 06635a35d13d: "flow_dissect: use programable dissector in
skb_flow_dissect and friends" from May 12, 2015, leads to the
following static checker warning:
net/core/flow_dissector.c:283 __skb_flow_dissect()
info: ignoring unreachable code.
net/core/flow_dissector.c
279
280 if (skb_flow_dissector_uses_key(flow_dissector,
281 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS)) {
282 return true;
^^^^^^^^^^^^
283 key_addrs = skb_flow_dissector_target(flow_dissector,
284 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
285 target_container);
286 key_addrs->src = hdr->srcnode;
287 key_addrs->dst = 0;
288 }
289 return true;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: flow_dissect: use programable dissector in skb_flow_dissect and friends
2015-05-15 9:54 flow_dissect: use programable dissector in skb_flow_dissect and friends Dan Carpenter
@ 2015-05-15 10:30 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2015-05-15 10:30 UTC (permalink / raw)
To: kernel-janitors
Fri, May 15, 2015 at 11:54:31AM CEST, dan.carpenter@oracle.com wrote:
>Hello Jiri Pirko,
>
>The patch 06635a35d13d: "flow_dissect: use programable dissector in
>skb_flow_dissect and friends" from May 12, 2015, leads to the
>following static checker warning:
>
> net/core/flow_dissector.c:283 __skb_flow_dissect()
> info: ignoring unreachable code.
>
>net/core/flow_dissector.c
> 279
> 280 if (skb_flow_dissector_uses_key(flow_dissector,
> 281 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS)) {
> 282 return true;
> ^^^^^^^^^^^^
> 283 key_addrs = skb_flow_dissector_target(flow_dissector,
> 284 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
> 285 target_container);
> 286 key_addrs->src = hdr->srcnode;
> 287 key_addrs->dst = 0;
> 288 }
> 289 return true;
>
>regards,
>dan carpenter
Will fix that.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-15 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-15 9:54 flow_dissect: use programable dissector in skb_flow_dissect and friends Dan Carpenter
2015-05-15 10:30 ` Jiri Pirko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.