From: Ralf Baechle <ralf@linux-mips.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org, Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH 1/2] MIPS: cpu: Alter MIPS_CPU_* definitions to fill gap
Date: Fri, 15 May 2015 21:14:43 +0200 [thread overview]
Message-ID: <20150515191443.GF2322@linux-mips.org> (raw)
In-Reply-To: <1431530234-32460-2-git-send-email-james.hogan@imgtec.com>
On Wed, May 13, 2015 at 04:17:13PM +0100, James Hogan wrote:
> The MIPS_CPU_* definitions accidentally missed bits 27..30 when
> MIPS_CPU_EVA was added, and further definitions have continued from
> there.
>
> Shift all the definitions since MIPS_CPU_EVA right by 4 so there are no
> gaps.
I like the patches but I think there is a bit more cleanup to be done
here. For one, we're using long longs to store the CPU feature flags
and while recent versions of GCC appear to be smarter, older versions
used to load both 32 bit words of a long long into a register for any
kind of arithmetic or test on the value. So I'd be happy if we could
go back to sorting bits in an array of longs. And then maybe use
test_bit() for testing the bits. And use an enum to number the bits.
After solving the include ordering issue, that is ...
Ralf
next prev parent reply other threads:[~2015-05-15 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:17 [PATCH 0/2] MIPS: cpu: Clean up MIPS_CPU_* definitions James Hogan
2015-05-13 15:17 ` James Hogan
2015-05-13 15:17 ` [PATCH 1/2] MIPS: cpu: Alter MIPS_CPU_* definitions to fill gap James Hogan
2015-05-13 15:17 ` James Hogan
2015-05-15 19:14 ` Ralf Baechle [this message]
2015-05-16 1:42 ` Maciej W. Rozycki
2015-05-13 15:17 ` [PATCH 2/2] MIPS: cpu: Convert MIPS_CPU_* defs to (1ull << x) James Hogan
2015-05-13 15:17 ` James Hogan
2015-05-13 15:38 ` Ezequiel Garcia
2015-05-13 16:01 ` James Hogan
2015-05-13 16:01 ` James Hogan
2015-05-13 17:22 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515191443.GF2322@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.