[PATCH RESEND] mips:Fix build error for ip32_defconfig configuration

[PATCH RESEND] mips:Fix build error for ip32_defconfig configuration

[Nicholas Krause]

This fixes the make error when building the ip32_defconfig
configuration due to using sgio2_cmos_devinit rather then
the correct function,sgio2_rtc_devinit in a device_initcall
below this function's definition.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 arch/mips/sgi-ip32/ip32-platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/sgi-ip32/ip32-platform.c b/arch/mips/sgi-ip32/ip32-platform.c
index 0134db2..2a7efcb 100644
--- a/arch/mips/sgi-ip32/ip32-platform.c
+++ b/arch/mips/sgi-ip32/ip32-platform.c
@@ -130,9 +130,9 @@ struct platform_device ip32_rtc_device = {
 	.resource		= ip32_rtc_resources,
 };
 
-+static int __init sgio2_rtc_devinit(void)
+static  __init int sgio2_rtc_devinit(void)
 {
 	return platform_device_register(&ip32_rtc_device);
 }
 
-device_initcall(sgio2_cmos_devinit);
+device_initcall(sgio2_rtc_devinit);
-- 
2.1.4

Re: [PATCH RESEND] mips:Fix build error for ip32_defconfig configuration

[Ralf Baechle]

On Thu, May 14, 2015 at 10:20:17AM -0400, Nicholas Krause wrote:

> This fixes the make error when building the ip32_defconfig
> configuration due to using sgio2_cmos_devinit rather then
> the correct function,sgio2_rtc_devinit in a device_initcall
> below this function's definition.

I've already applied Joshua Kinard's 
https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic
touchup.

  Ralf

Re: [PATCH RESEND] mips:Fix build error for ip32_defconfig configuration

[nick]

On 2015-05-15 04:10 PM, Ralf Baechle wrote:
> On Thu, May 14, 2015 at 10:20:17AM -0400, Nicholas Krause wrote:
> 
>> This fixes the make error when building the ip32_defconfig
>> configuration due to using sgio2_cmos_devinit rather then
>> the correct function,sgio2_rtc_devinit in a device_initcall
>> below this function's definition.
> 
> I've already applied Joshua Kinard's 
> https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic
> touchup.
> 
>   Ralf
> 
Ralf,
As you may already known my rep with the other kernel developers is pretty bad.
Based off this work can you try(time permitting) to put it a good word that I am
improving.
Thanks Nick

Re: [PATCH RESEND] mips:Fix build error for ip32_defconfig configuration

[Ralf Baechle]

On Fri, May 15, 2015 at 04:16:59PM -0400, nick wrote:

> On 2015-05-15 04:10 PM, Ralf Baechle wrote:
> > On Thu, May 14, 2015 at 10:20:17AM -0400, Nicholas Krause wrote:
> > 
> >> This fixes the make error when building the ip32_defconfig
> >> configuration due to using sgio2_cmos_devinit rather then
> >> the correct function,sgio2_rtc_devinit in a device_initcall
> >> below this function's definition.
> > 
> > I've already applied Joshua Kinard's 
> > https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic
> > touchup.
> > 
> >   Ralf
> > 
> Ralf,
> As you may already known my rep with the other kernel developers is pretty bad.
> Based off this work can you try(time permitting) to put it a good word that I am
> improving.

The kernel world is a meritocracy.  Which means your status will depend
on the value of your contributions.  So I think there's not much I could
or should do but to let your merrits aka patches speak for themselves.

  Ralf

Re: [PATCH RESEND] mips:Fix build error for ip32_defconfig configuration

[Nicholas Krause]

On May 15, 2015 4:45:46 PM EDT, Ralf Baechle <ralf@linux-mips.org> wrote:
>On Fri, May 15, 2015 at 04:16:59PM -0400, nick wrote:
>
>> On 2015-05-15 04:10 PM, Ralf Baechle wrote:
>> > On Thu, May 14, 2015 at 10:20:17AM -0400, Nicholas Krause wrote:
>> > 
>> >> This fixes the make error when building the ip32_defconfig
>> >> configuration due to using sgio2_cmos_devinit rather then
>> >> the correct function,sgio2_rtc_devinit in a device_initcall
>> >> below this function's definition.
>> > 
>> > I've already applied Joshua Kinard's 
>> > https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic
>> > touchup.
>> > 
>> >   Ralf
>> > 
>> Ralf,
>> As you may already known my rep with the other kernel developers is
>pretty bad.
>> Based off this work can you try(time permitting) to put it a good
>word that I am
>> improving.
>
>The kernel world is a meritocracy.  Which means your status will depend
>on the value of your contributions.  So I think there's not much I
>could
>or should do but to let your merrits aka patches speak for themselves.
>
>  Ralf
Very well then thanks anyway. 
Nick 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.