From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: Kinglong Mee <kinglongmee@gmail.com>,
linux-fsdevel@vger.kernel.org,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: [PATCH 4/4] nfsd: Pin to vfsmnt instead of mntget
Date: Fri, 15 May 2015 17:11:34 -0400 [thread overview]
Message-ID: <20150515211134.GG29627@fieldses.org> (raw)
In-Reply-To: <20150513142515.6bd881c8@notabene.brown>
On Wed, May 13, 2015 at 02:25:15PM +1000, NeilBrown wrote:
> On Mon, 11 May 2015 21:08:47 +0800 Kinglong Mee <kinglongmee@gmail.com> wrote:
>
> > On 5/8/2015 9:47 PM, J. Bruce Fields wrote:
> > > It could also be useful to have the ability to force an unmount even in
> > > the presence of locks. That's not a safe default, but an
> > > "allow_force_unmount" export option might be useful.
>
> We already have a mechanism to forcibly drop any locks by writing some magic
> to /proc/fs/nfsd/unlock_{ip,filesystem}. I don't think we need any more.
Yeah, I remember thinking this sort of approach would have advantages,
maybe I was wrong, I need to revisit it.
The unlock_{ip,filesystem} approach requires temporarily shutting down
mountd, doesn't it?
--b.
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: NeilBrown <neilb-l3A5Bk7waGM@public.gmane.org>
Cc: Kinglong Mee
<kinglongmee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Subject: Re: [PATCH 4/4] nfsd: Pin to vfsmnt instead of mntget
Date: Fri, 15 May 2015 17:11:34 -0400 [thread overview]
Message-ID: <20150515211134.GG29627@fieldses.org> (raw)
In-Reply-To: <20150513142515.6bd881c8-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
On Wed, May 13, 2015 at 02:25:15PM +1000, NeilBrown wrote:
> On Mon, 11 May 2015 21:08:47 +0800 Kinglong Mee <kinglongmee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> > On 5/8/2015 9:47 PM, J. Bruce Fields wrote:
> > > It could also be useful to have the ability to force an unmount even in
> > > the presence of locks. That's not a safe default, but an
> > > "allow_force_unmount" export option might be useful.
>
> We already have a mechanism to forcibly drop any locks by writing some magic
> to /proc/fs/nfsd/unlock_{ip,filesystem}. I don't think we need any more.
Yeah, I remember thinking this sort of approach would have advantages,
maybe I was wrong, I need to revisit it.
The unlock_{ip,filesystem} approach requires temporarily shutting down
mountd, doesn't it?
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-15 21:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 13:18 [PATCH 0/4] NFSD: Pin to vfsmount instead of mntget for export cache Kinglong Mee
2015-05-06 13:19 ` [PATCH 1/4] fs_pin: Fix uninitialized value in fs_pin Kinglong Mee
2015-05-06 13:19 ` Kinglong Mee
2015-05-07 19:43 ` J. Bruce Fields
2015-05-08 0:36 ` Kinglong Mee
2015-05-08 0:36 ` Kinglong Mee
2015-05-06 13:19 ` [PATCH 2/4] fs_pin: Export functions for specific filesystem Kinglong Mee
2015-05-06 13:19 ` Kinglong Mee
2015-05-06 13:20 ` [PATCH 3/4] sunrpc: New helper cache_force_expire for cache cleanup Kinglong Mee
2015-05-06 13:20 ` Kinglong Mee
2015-05-06 13:21 ` [PATCH 4/4] nfsd: Pin to vfsmnt instead of mntget Kinglong Mee
2015-05-06 13:21 ` Kinglong Mee
2015-05-08 4:40 ` NeilBrown
2015-05-08 13:47 ` J. Bruce Fields
2015-05-11 13:08 ` Kinglong Mee
2015-05-13 4:25 ` NeilBrown
2015-05-13 4:25 ` NeilBrown
2015-05-13 12:30 ` Kinglong Mee
2015-05-13 12:55 ` Kinglong Mee
2015-05-13 12:55 ` Kinglong Mee
2015-05-15 21:11 ` J. Bruce Fields [this message]
2015-05-15 21:11 ` J. Bruce Fields
2015-05-15 23:23 ` NeilBrown
2015-05-22 15:02 ` Kinglong Mee
2015-05-22 16:03 ` J. Bruce Fields
2015-05-15 21:09 ` J. Bruce Fields
2015-05-15 21:09 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515211134.GG29627@fieldses.org \
--to=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.