From: "Pali Rohár" <pali.rohar@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
"Rob Herring" <robherring2@gmail.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Will Deacon" <will.deacon@arm.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Sebastian Reichel" <sre@debian.org>,
"Pavel Machek" <pavel@ucw.cz>, "Tony Lindgren" <tony@atomide.com>,
"Andreas Färber" <afaerber@suse.de>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm: boot: store ATAG structure into DT atags field
Date: Fri, 15 May 2015 22:16:24 +0200 [thread overview]
Message-ID: <201505152216.24622@pali> (raw)
In-Reply-To: <3513646.XX80DTTJbc@wuerfel>
[-- Attachment #1: Type: Text/Plain, Size: 1213 bytes --]
On Friday 15 May 2015 22:12:41 Arnd Bergmann wrote:
> On Friday 15 May 2015 21:50:07 Pali Rohár wrote:
> > }
> >
> > }
> >
> > + /* include the terminating ATAG_NONE */
> > + atag_size = (char *)atag - (char *)atag_list +
> > sizeof(struct tag_header); + setprop(fdt, "/", "atags",
> > atag_list, atag_size);
> > +
> >
> > if (memcount) {
> >
> > setprop(fdt, "/memory", "reg", mem_reg_property,
> >
> > 4 * memcount * memsize);
>
> The property should probably have a DT binding, and be named
> "linux,atags".
>
> It may also help to check if the "linux,atags" property already
> exists and not create it otherwise. That way we can put it into the
> n900 dts file and have it updated by the compat code, but not expose
> the atags on other platforms unless they opt in.
>
> Arnd
Maybe what would help: Is there a way to tell decompressor/kernel to not
touch atag memory and then after kernel/board-code starts it save copy
of atags? I think it is not possible right now, but correct me if I'm
wrong...
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: boot: store ATAG structure into DT atags field
Date: Fri, 15 May 2015 22:16:24 +0200 [thread overview]
Message-ID: <201505152216.24622@pali> (raw)
In-Reply-To: <3513646.XX80DTTJbc@wuerfel>
On Friday 15 May 2015 22:12:41 Arnd Bergmann wrote:
> On Friday 15 May 2015 21:50:07 Pali Roh?r wrote:
> > }
> >
> > }
> >
> > + /* include the terminating ATAG_NONE */
> > + atag_size = (char *)atag - (char *)atag_list +
> > sizeof(struct tag_header); + setprop(fdt, "/", "atags",
> > atag_list, atag_size);
> > +
> >
> > if (memcount) {
> >
> > setprop(fdt, "/memory", "reg", mem_reg_property,
> >
> > 4 * memcount * memsize);
>
> The property should probably have a DT binding, and be named
> "linux,atags".
>
> It may also help to check if the "linux,atags" property already
> exists and not create it otherwise. That way we can put it into the
> n900 dts file and have it updated by the compat code, but not expose
> the atags on other platforms unless they opt in.
>
> Arnd
Maybe what would help: Is there a way to tell decompressor/kernel to not
touch atag memory and then after kernel/board-code starts it save copy
of atags? I think it is not possible right now, but correct me if I'm
wrong...
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150515/bf454953/attachment.sig>
next prev parent reply other threads:[~2015-05-15 20:16 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 8:49 [RESEND] [PATCH v2 0/2] ARM: /proc/cpuinfo: DT: Add support for Revision Pali Rohár
2015-05-06 8:49 ` Pali Rohár
2015-05-06 8:49 ` Pali Rohár
2015-05-06 8:49 ` [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision Pali Rohár
2015-05-06 8:49 ` Pali Rohár
2015-05-06 8:49 ` Pali Rohár
2015-05-06 9:31 ` Arnd Bergmann
2015-05-06 9:31 ` Arnd Bergmann
2015-05-06 10:37 ` Pali Rohár
2015-05-06 10:37 ` Pali Rohár
2015-05-06 10:37 ` Pali Rohár
2015-05-06 11:04 ` Arnd Bergmann
2015-05-06 11:04 ` Arnd Bergmann
2015-05-06 11:44 ` Pali Rohár
2015-05-06 11:44 ` Pali Rohár
2015-05-06 11:44 ` Pali Rohár
2015-06-25 5:01 ` Tony Lindgren
2015-06-25 5:01 ` Tony Lindgren
2015-06-25 7:18 ` Pali Rohár
2015-06-25 7:18 ` Pali Rohár
2015-06-25 7:22 ` Tony Lindgren
2015-06-25 7:22 ` Tony Lindgren
2015-06-25 7:22 ` Tony Lindgren
2015-06-25 7:27 ` Pali Rohár
2015-06-25 7:27 ` Pali Rohár
2015-06-25 7:41 ` Tony Lindgren
2015-06-25 7:41 ` Tony Lindgren
2015-06-25 7:41 ` Tony Lindgren
[not found] ` <20150625050138.GL4156-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-07-06 12:23 ` Pali Rohár
2015-07-06 12:23 ` Pali Rohár
2015-07-06 12:23 ` Pali Rohár
2015-07-06 12:31 ` Tony Lindgren
2015-07-06 12:31 ` Tony Lindgren
[not found] ` <20150706123126.GG10705-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-07-06 13:12 ` Pali Rohár
2015-07-06 13:12 ` Pali Rohár
2015-07-06 13:12 ` Pali Rohár
2015-07-06 13:55 ` Tony Lindgren
2015-07-06 13:55 ` Tony Lindgren
2015-07-06 13:55 ` Tony Lindgren
2015-07-06 15:22 ` Rob Herring
2015-07-06 15:22 ` Rob Herring
[not found] ` <CAL_Jsq+ysDqxTgfW1JvG5czHa4UkZQDv1BN63iK4jvV9kDXM8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-06 16:20 ` Pali Rohár
2015-07-06 16:20 ` Pali Rohár
2015-07-06 16:20 ` Pali Rohár
2015-07-06 16:36 ` Pali Rohár
2015-07-06 16:36 ` Pali Rohár
2015-07-06 17:30 ` Rob Herring
2015-07-06 17:30 ` Rob Herring
2015-07-06 15:20 ` Rob Herring
2015-07-06 15:20 ` Rob Herring
2015-07-06 15:24 ` Tony Lindgren
2015-07-06 15:24 ` Tony Lindgren
2015-06-25 10:03 ` Russell King - ARM Linux
2015-06-25 10:03 ` Russell King - ARM Linux
2015-06-25 10:03 ` Russell King - ARM Linux
2015-05-06 8:49 ` [RESEND] [PATCH v2 2/2] arm: boot: convert ATAG_REVISION to DT revision field Pali Rohár
2015-05-06 8:49 ` Pali Rohár
2015-05-06 8:49 ` Pali Rohár
2015-05-15 19:50 ` [PATCH 0/2] ARM: /proc/atags: Export also for DT Pali Rohár
2015-05-15 19:50 ` Pali Rohár
2015-05-15 19:50 ` Pali Rohár
2015-05-15 19:50 ` [PATCH 1/2] arm: devtree: Save atags if are in DT atags field Pali Rohár
2015-05-15 19:50 ` Pali Rohár
2015-05-15 20:09 ` Arnd Bergmann
2015-05-15 20:09 ` Arnd Bergmann
2015-06-25 5:06 ` Tony Lindgren
2015-06-25 5:06 ` Tony Lindgren
2015-05-15 19:50 ` [PATCH 2/2] arm: boot: store ATAG structure into " Pali Rohár
2015-05-15 19:50 ` Pali Rohár
2015-05-15 20:12 ` Arnd Bergmann
2015-05-15 20:12 ` Arnd Bergmann
2015-05-15 20:12 ` Arnd Bergmann
2015-05-15 20:16 ` Pali Rohár [this message]
2015-05-15 20:16 ` Pali Rohár
2015-05-15 20:21 ` Arnd Bergmann
2015-05-15 20:21 ` Arnd Bergmann
2015-05-15 20:21 ` Arnd Bergmann
2015-06-25 5:12 ` Tony Lindgren
2015-06-25 5:12 ` Tony Lindgren
2015-06-25 10:02 ` [PATCH 0/2] ARM: /proc/atags: Export also for DT Russell King - ARM Linux
2015-06-25 10:02 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505152216.24622@pali \
--to=pali.rohar@gmail.com \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pavel@ucw.cz \
--cc=robherring2@gmail.com \
--cc=sre@debian.org \
--cc=tony@atomide.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.