From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: LABBE Corentin <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v9] crypto: Add Allwinner Security System crypto accelerator
Date: Sun, 17 May 2015 09:45:53 +0200 [thread overview]
Message-ID: <20150517094553.7fd8d8a0@bbrezillon> (raw)
In-Reply-To: <1431608341-10936-1-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello Corentin,
On Thu, 14 May 2015 14:58:57 +0200
LABBE Corentin <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> Hello
>
> This is the driver for the Security System included in Allwinner SoC A20.
> The Security System (SS for short) is a hardware cryptographic accelerator that
> support AES/MD5/SHA1/DES/3DES/PRNG algorithms.
> It could be found on others Allwinner SoC:
> - A10, A10s, A13, A31 and A33 manual give the same datasheet for SS than A20
> - A23 speak about a security system but without precisions
> - A80 and A83T datasheet speak about a security system with more functions
> (SHA224/SHA256/RSA/CRC), they will be supported in a separate driver
> But I do not have access on any of those hardware, tests are welcome.
>
Maybe this is just a nitpick, but I would reverse the ordering of
patches in this series. The biggest inconsistency is the fact that
you're adding yourself as a maintainer of something that does not even
exist.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9] crypto: Add Allwinner Security System crypto accelerator
Date: Sun, 17 May 2015 09:45:53 +0200 [thread overview]
Message-ID: <20150517094553.7fd8d8a0@bbrezillon> (raw)
In-Reply-To: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com>
Hello Corentin,
On Thu, 14 May 2015 14:58:57 +0200
LABBE Corentin <clabbe.montjoie@gmail.com> wrote:
>
> Hello
>
> This is the driver for the Security System included in Allwinner SoC A20.
> The Security System (SS for short) is a hardware cryptographic accelerator that
> support AES/MD5/SHA1/DES/3DES/PRNG algorithms.
> It could be found on others Allwinner SoC:
> - A10, A10s, A13, A31 and A33 manual give the same datasheet for SS than A20
> - A23 speak about a security system but without precisions
> - A80 and A83T datasheet speak about a security system with more functions
> (SHA224/SHA256/RSA/CRC), they will be supported in a separate driver
> But I do not have access on any of those hardware, tests are welcome.
>
Maybe this is just a nitpick, but I would reverse the ordering of
patches in this series. The biggest inconsistency is the fact that
you're adding yourself as a maintainer of something that does not even
exist.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
maxime.ripard@free-electrons.com, linux@arm.linux.org.uk,
herbert@gondor.apana.org.au, davem@davemloft.net,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
mchehab@osg.samsung.com, joe@perches.com, tj@kernel.org,
arnd@arndb.de, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v9] crypto: Add Allwinner Security System crypto accelerator
Date: Sun, 17 May 2015 09:45:53 +0200 [thread overview]
Message-ID: <20150517094553.7fd8d8a0@bbrezillon> (raw)
In-Reply-To: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com>
Hello Corentin,
On Thu, 14 May 2015 14:58:57 +0200
LABBE Corentin <clabbe.montjoie@gmail.com> wrote:
>
> Hello
>
> This is the driver for the Security System included in Allwinner SoC A20.
> The Security System (SS for short) is a hardware cryptographic accelerator that
> support AES/MD5/SHA1/DES/3DES/PRNG algorithms.
> It could be found on others Allwinner SoC:
> - A10, A10s, A13, A31 and A33 manual give the same datasheet for SS than A20
> - A23 speak about a security system but without precisions
> - A80 and A83T datasheet speak about a security system with more functions
> (SHA224/SHA256/RSA/CRC), they will be supported in a separate driver
> But I do not have access on any of those hardware, tests are welcome.
>
Maybe this is just a nitpick, but I would reverse the ordering of
patches in this series. The biggest inconsistency is the fact that
you're adding yourself as a maintainer of something that does not even
exist.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-17 7:45 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 12:58 [PATCH v9] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2015-05-14 12:58 ` LABBE Corentin
2015-05-14 12:58 ` LABBE Corentin
2015-05-14 12:58 ` [PATCH v9 2/4] ARM: sun4i: dt: Add DT bindings documentation for SUN4I Security System LABBE Corentin
2015-05-14 12:58 ` LABBE Corentin
[not found] ` <1431608341-10936-1-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-14 12:58 ` [PATCH v9 1/4] ARM: sun7i: dt: Add Security System to A20 SoC DTS LABBE Corentin
2015-05-14 12:58 ` LABBE Corentin
2015-05-14 12:58 ` LABBE Corentin
2015-05-15 7:31 ` Maxime Ripard
2015-05-15 7:31 ` Maxime Ripard
2015-05-23 12:08 ` Corentin LABBE
2015-05-23 12:08 ` Corentin LABBE
2015-05-23 12:08 ` Corentin LABBE
2015-05-14 12:59 ` [PATCH v9 3/4] MAINTAINERS: Add myself as maintainer of Allwinner Security System LABBE Corentin
2015-05-14 12:59 ` LABBE Corentin
2015-05-14 12:59 ` LABBE Corentin
2015-05-14 12:59 ` [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2015-05-14 12:59 ` LABBE Corentin
2015-05-14 12:59 ` LABBE Corentin
2015-05-15 6:52 ` Herbert Xu
2015-05-15 6:52 ` Herbert Xu
[not found] ` <20150515065222.GA16808-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-16 18:09 ` Corentin LABBE
2015-05-16 18:09 ` [linux-sunxi] " Corentin LABBE
2015-05-16 18:09 ` Corentin LABBE
2015-05-17 1:32 ` Herbert Xu
2015-05-17 1:32 ` Herbert Xu
[not found] ` <1431608341-10936-5-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-15 6:49 ` Herbert Xu
2015-05-15 6:49 ` Herbert Xu
2015-05-15 6:49 ` Herbert Xu
[not found] ` <20150515064932.GB16704-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-23 12:18 ` Corentin LABBE
2015-05-23 12:18 ` [linux-sunxi] " Corentin LABBE
2015-05-23 12:18 ` Corentin LABBE
2015-05-24 3:30 ` Herbert Xu
2015-05-24 3:30 ` Herbert Xu
2015-05-17 8:45 ` Boris Brezillon
2015-05-17 8:45 ` Boris Brezillon
2015-05-17 8:45 ` Boris Brezillon
2015-05-17 10:34 ` Herbert Xu
2015-05-17 10:34 ` Herbert Xu
2015-05-17 10:34 ` Herbert Xu
[not found] ` <20150517103440.GA7800-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-17 10:48 ` Boris Brezillon
2015-05-17 10:48 ` Boris Brezillon
2015-05-17 10:48 ` Boris Brezillon
2015-05-18 0:41 ` Herbert Xu
2015-05-18 0:41 ` Herbert Xu
2015-05-18 0:41 ` Herbert Xu
[not found] ` <20150518004121.GA11910-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-18 7:24 ` Boris Brezillon
2015-05-18 7:24 ` Boris Brezillon
2015-05-18 7:24 ` Boris Brezillon
2015-05-18 8:33 ` Herbert Xu
2015-05-18 8:33 ` Herbert Xu
2015-05-23 13:12 ` Corentin LABBE
2015-05-23 13:12 ` Corentin LABBE
2015-05-23 13:12 ` Corentin LABBE
[not found] ` <55607CB7.8020505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-23 14:35 ` Boris Brezillon
2015-05-23 14:35 ` Boris Brezillon
2015-05-23 14:35 ` Boris Brezillon
2015-05-24 3:32 ` Herbert Xu
2015-05-24 3:32 ` Herbert Xu
2015-05-24 8:04 ` [linux-sunxi] " Corentin LABBE
2015-05-24 8:04 ` Corentin LABBE
[not found] ` <55618600.6040904-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-24 8:12 ` Herbert Xu
2015-05-24 8:12 ` [linux-sunxi] " Herbert Xu
2015-05-24 8:12 ` Herbert Xu
2015-06-03 19:06 ` Corentin LABBE
2015-06-03 19:06 ` Corentin LABBE
2015-06-03 19:06 ` Corentin LABBE
2015-05-17 7:45 ` Boris Brezillon [this message]
2015-05-17 7:45 ` [PATCH v9] " Boris Brezillon
2015-05-17 7:45 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150517094553.7fd8d8a0@bbrezillon \
--to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.