From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] max7359_keypad: implement DT bindings
Date: Mon, 18 May 2015 09:53:17 -0700 [thread overview]
Message-ID: <20150518165317.GC19708@dtor-ws> (raw)
In-Reply-To: <20150517165502.GA781@fifteen>
On Sun, May 17, 2015 at 07:55:02PM +0300, Evgeniy Dushistov wrote:
> On Fri, May 15, 2015 at 11:00:02PM +0200, Dmitry Torokhov wrote:
> > On Thu, May 14, 2015 at 05:38:03AM +0300, Evgeniy Dushistov wrote:
> > > + maxim,debounce_reg = /bits/ 8 <0x5F>;
> > > + maxim,ports_reg = /bits/ 8 <0xFF>;
> >
> > Specifying exact size for properties is quite uncommon; I think the
> > usual recommendation is is to use the "standard" u32 and validate the
> > range in parser function.
> >
>
> Using of u8 has advantages, it is possible on compilation stage
> (dts->dtb) check that you enter right value, but
> because of DT validation tools are not part of mainline,
> I replace u8 with u32 as you suggest, see patch bellow.
If you get DT folks OK on using /bits/ I'm fine with keeping it.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 3/3] max7359_keypad: implement DT bindings
Date: Mon, 18 May 2015 09:53:17 -0700 [thread overview]
Message-ID: <20150518165317.GC19708@dtor-ws> (raw)
In-Reply-To: <20150517165502.GA781@fifteen>
On Sun, May 17, 2015 at 07:55:02PM +0300, Evgeniy Dushistov wrote:
> On Fri, May 15, 2015 at 11:00:02PM +0200, Dmitry Torokhov wrote:
> > On Thu, May 14, 2015 at 05:38:03AM +0300, Evgeniy Dushistov wrote:
> > > + maxim,debounce_reg = /bits/ 8 <0x5F>;
> > > + maxim,ports_reg = /bits/ 8 <0xFF>;
> >
> > Specifying exact size for properties is quite uncommon; I think the
> > usual recommendation is is to use the "standard" u32 and validate the
> > range in parser function.
> >
>
> Using of u8 has advantages, it is possible on compilation stage
> (dts->dtb) check that you enter right value, but
> because of DT validation tools are not part of mainline,
> I replace u8 with u32 as you suggest, see patch bellow.
If you get DT folks OK on using /bits/ I'm fine with keeping it.
--
Dmitry
next prev parent reply other threads:[~2015-05-18 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ppRxn-3aD-5@gated-at.bofh.it>
[not found] ` <pquS6-2DV-9@gated-at.bofh.it>
2015-05-17 16:55 ` [PATCH 3/3] max7359_keypad: implement DT bindings Evgeniy Dushistov
2015-05-18 16:53 ` Dmitry Torokhov [this message]
2015-05-18 16:53 ` Dmitry Torokhov
2015-05-18 17:02 ` Dmitry Torokhov
2015-05-18 17:02 ` Dmitry Torokhov
2015-05-14 2:38 Evgeniy Dushistov
2015-05-15 20:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518165317.GC19708@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.