From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Nam T. Nguyen" <namnguyen@chromium.org>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
sque@chromium.org, linux-kernel@vger.kernel.org,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v2] perf: Separate the tests and tools in installation
Date: Mon, 18 May 2015 17:22:38 -0300 [thread overview]
Message-ID: <20150518202238.GD18563@kernel.org> (raw)
In-Reply-To: <1431974247-22275-1-git-send-email-namnguyen@chromium.org>
Em Mon, May 18, 2015 at 11:37:27AM -0700, Nam T. Nguyen escreveu:
> This refactors out install-bin to install-tests and install-tools so
> that downstream could opt to only install the tools, and not the tests.
>
> Change-Id: Idfac38ca6fcb3057baeda416591473c9d86dffe9
What is this 'Change-Id': tag? Something specific to the Chromium
project? I'll keep it, but wonder if what would be the sense for this
in the Linux kernel source repo...
- Arnaldo
> Signed-off-by: Nam T. Nguyen <namnguyen@chromium.org>
> ---
> Changes from v1:
>
> * Keep original target dependencies
>
> tools/perf/Makefile.perf | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 7257e7e..2cb98db 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -830,7 +830,7 @@ check: $(OUTPUT)common-cmds.h
>
> install-gtk:
>
> -install-bin: all install-gtk
> +install-tools: all install-gtk
> $(call QUIET_INSTALL, binaries) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'; \
> $(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)'; \
> @@ -858,12 +858,16 @@ endif
> $(call QUIET_INSTALL, perf_completion-script) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
> $(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
> +
> +install-tests: all install-gtk
> $(call QUIET_INSTALL, tests) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> $(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
> $(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'
>
> +install-bin: install-tools install-tests
> +
> install: install-bin try-install-man install-traceevent-plugins
>
> install-python_ext:
> --
> 2.2.0.rc0.207.ga3a616c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-05-18 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 18:37 [PATCH v2] perf: Separate the tests and tools in installation Nam T. Nguyen
2015-05-18 20:22 ` Arnaldo Carvalho de Melo [this message]
2015-05-27 16:45 ` [tip:perf/core] perf tools: " tip-bot for Nam T. Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518202238.GD18563@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namnguyen@chromium.org \
--cc=paulus@samba.org \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.