* [PATCH v2] perf: Separate the tests and tools in installation
@ 2015-05-18 18:37 Nam T. Nguyen
2015-05-18 20:22 ` Arnaldo Carvalho de Melo
2015-05-27 16:45 ` [tip:perf/core] perf tools: " tip-bot for Nam T. Nguyen
0 siblings, 2 replies; 3+ messages in thread
From: Nam T. Nguyen @ 2015-05-18 18:37 UTC (permalink / raw)
To: a.p.zijlstra, paulus, mingo, acme; +Cc: sque, linux-kernel, Nam T. Nguyen
This refactors out install-bin to install-tests and install-tools so
that downstream could opt to only install the tools, and not the tests.
Change-Id: Idfac38ca6fcb3057baeda416591473c9d86dffe9
Signed-off-by: Nam T. Nguyen <namnguyen@chromium.org>
---
Changes from v1:
* Keep original target dependencies
tools/perf/Makefile.perf | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 7257e7e..2cb98db 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -830,7 +830,7 @@ check: $(OUTPUT)common-cmds.h
install-gtk:
-install-bin: all install-gtk
+install-tools: all install-gtk
$(call QUIET_INSTALL, binaries) \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'; \
$(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)'; \
@@ -858,12 +858,16 @@ endif
$(call QUIET_INSTALL, perf_completion-script) \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
$(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
+
+install-tests: all install-gtk
$(call QUIET_INSTALL, tests) \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
$(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
$(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'
+install-bin: install-tools install-tests
+
install: install-bin try-install-man install-traceevent-plugins
install-python_ext:
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] perf: Separate the tests and tools in installation
2015-05-18 18:37 [PATCH v2] perf: Separate the tests and tools in installation Nam T. Nguyen
@ 2015-05-18 20:22 ` Arnaldo Carvalho de Melo
2015-05-27 16:45 ` [tip:perf/core] perf tools: " tip-bot for Nam T. Nguyen
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-05-18 20:22 UTC (permalink / raw)
To: Nam T. Nguyen; +Cc: a.p.zijlstra, paulus, mingo, sque, linux-kernel, Jiri Olsa
Em Mon, May 18, 2015 at 11:37:27AM -0700, Nam T. Nguyen escreveu:
> This refactors out install-bin to install-tests and install-tools so
> that downstream could opt to only install the tools, and not the tests.
>
> Change-Id: Idfac38ca6fcb3057baeda416591473c9d86dffe9
What is this 'Change-Id': tag? Something specific to the Chromium
project? I'll keep it, but wonder if what would be the sense for this
in the Linux kernel source repo...
- Arnaldo
> Signed-off-by: Nam T. Nguyen <namnguyen@chromium.org>
> ---
> Changes from v1:
>
> * Keep original target dependencies
>
> tools/perf/Makefile.perf | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 7257e7e..2cb98db 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -830,7 +830,7 @@ check: $(OUTPUT)common-cmds.h
>
> install-gtk:
>
> -install-bin: all install-gtk
> +install-tools: all install-gtk
> $(call QUIET_INSTALL, binaries) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'; \
> $(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)'; \
> @@ -858,12 +858,16 @@ endif
> $(call QUIET_INSTALL, perf_completion-script) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
> $(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
> +
> +install-tests: all install-gtk
> $(call QUIET_INSTALL, tests) \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> $(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
> $(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'
>
> +install-bin: install-tools install-tests
> +
> install: install-bin try-install-man install-traceevent-plugins
>
> install-python_ext:
> --
> 2.2.0.rc0.207.ga3a616c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf tools: Separate the tests and tools in installation
2015-05-18 18:37 [PATCH v2] perf: Separate the tests and tools in installation Nam T. Nguyen
2015-05-18 20:22 ` Arnaldo Carvalho de Melo
@ 2015-05-27 16:45 ` tip-bot for Nam T. Nguyen
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Nam T. Nguyen @ 2015-05-27 16:45 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, acme, mingo, jolsa, a.p.zijlstra, tglx, paulus,
sque, namnguyen
Commit-ID: 128c32ed1866e6cf3d3944e7dcdcea06bc060b0d
Gitweb: http://git.kernel.org/tip/128c32ed1866e6cf3d3944e7dcdcea06bc060b0d
Author: Nam T. Nguyen <namnguyen@chromium.org>
AuthorDate: Mon, 18 May 2015 11:37:27 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 27 May 2015 12:21:43 -0300
perf tools: Separate the tests and tools in installation
This refactors out install-bin to install-tests and install-tools so
that downstream could opt to only install the tools, and not the tests.
Signed-off-by: Nam T. Nguyen <namnguyen@chromium.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Simon Que <sque@chromium.org>
Link: http://lkml.kernel.org/r/1431974247-22275-1-git-send-email-namnguyen@chromium.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.perf | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 03409cc..5816a3b 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -464,7 +464,7 @@ check: $(OUTPUT)common-cmds.h
install-gtk:
-install-bin: all install-gtk
+install-tools: all install-gtk
$(call QUIET_INSTALL, binaries) \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'; \
$(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)'; \
@@ -502,12 +502,16 @@ endif
$(call QUIET_INSTALL, perf_completion-script) \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
$(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
+
+install-tests: all install-gtk
$(call QUIET_INSTALL, tests) \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
$(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
$(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'
+install-bin: install-tools install-tests
+
install: install-bin try-install-man install-traceevent-plugins
install-python_ext:
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-27 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 18:37 [PATCH v2] perf: Separate the tests and tools in installation Nam T. Nguyen
2015-05-18 20:22 ` Arnaldo Carvalho de Melo
2015-05-27 16:45 ` [tip:perf/core] perf tools: " tip-bot for Nam T. Nguyen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.