From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board
Date: Tue, 19 May 2015 15:43:14 +0800 [thread overview]
Message-ID: <20150519074314.GT1071@dragon> (raw)
In-Reply-To: <555AE192.8010700@denx.de>
On Tue, May 19, 2015 at 09:09:06AM +0200, Heiko Schocher wrote:
> >>@@ -0,0 +1,124 @@
> >>+/*
> >>+ * support fot the imx6 based aristainetos2 board
> >>+ *
> >>+ * Copyright (C) 2015 Heiko Schocher <hs@denx.de>
> >>+ *
> >>+ * This program is free software; you can redistribute it and/or modify
> >>+ * it under the terms of the GNU General Public License version 2 as
> >>+ * published by the Free Software Foundation.
> >>+ *
> >>+ */
> >
> >GPL/X11 dual licence is suggested for new DTS files. See
> >arch/arm/boot/dts/imx6sl-warp.dts for an example.
>
> Ok, I ask the customer, if this is OK for him ...
The dual license get non-Linux users be able to use the DTS file.
[...]
> >>+&i2c3 {
> >>+ atmel: atmel_mxt_ts at 4b {
> >
> >Node name should be generic.
>
> So, what name do you prefer?
The node name with the example in bindings doc
Documentation/devicetree/bindings/input/atmel,maxtouch.txt seems
perfectly fine to me.
[...]
> >>+&i2c3 {
> >>+ atmel: atmel_mxt_ts at 4d {
> >>+ compatible = "atmel,maxtouch";
> >>+ reg = <0x4d>;
> >>+ interrupt-parent = <&gpio2>;
> >>+ interrupts = <9 8>;
> >>+ };
> >
> >It seems the touch device is identical between
> >imx6dl-aristainetos2_4.dts and imx6dl-aristainetos2_7.dts. Why don't
> >you put it into imx6qdl-aristainetos2.dtsi?
>
> They have different i2c addresses ...
Okay, I missed that.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board
Date: Tue, 19 May 2015 15:43:14 +0800 [thread overview]
Message-ID: <20150519074314.GT1071@dragon> (raw)
In-Reply-To: <555AE192.8010700@denx.de>
On Tue, May 19, 2015 at 09:09:06AM +0200, Heiko Schocher wrote:
> >>@@ -0,0 +1,124 @@
> >>+/*
> >>+ * support fot the imx6 based aristainetos2 board
> >>+ *
> >>+ * Copyright (C) 2015 Heiko Schocher <hs@denx.de>
> >>+ *
> >>+ * This program is free software; you can redistribute it and/or modify
> >>+ * it under the terms of the GNU General Public License version 2 as
> >>+ * published by the Free Software Foundation.
> >>+ *
> >>+ */
> >
> >GPL/X11 dual licence is suggested for new DTS files. See
> >arch/arm/boot/dts/imx6sl-warp.dts for an example.
>
> Ok, I ask the customer, if this is OK for him ...
The dual license get non-Linux users be able to use the DTS file.
[...]
> >>+&i2c3 {
> >>+ atmel: atmel_mxt_ts@4b {
> >
> >Node name should be generic.
>
> So, what name do you prefer?
The node name with the example in bindings doc
Documentation/devicetree/bindings/input/atmel,maxtouch.txt seems
perfectly fine to me.
[...]
> >>+&i2c3 {
> >>+ atmel: atmel_mxt_ts@4d {
> >>+ compatible = "atmel,maxtouch";
> >>+ reg = <0x4d>;
> >>+ interrupt-parent = <&gpio2>;
> >>+ interrupts = <9 8>;
> >>+ };
> >
> >It seems the touch device is identical between
> >imx6dl-aristainetos2_4.dts and imx6dl-aristainetos2_7.dts. Why don't
> >you put it into imx6qdl-aristainetos2.dtsi?
>
> They have different i2c addresses ...
Okay, I missed that.
Shawn
next prev parent reply other threads:[~2015-05-19 7:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 9:02 [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board Heiko Schocher
2015-05-11 9:02 ` Heiko Schocher
2015-05-11 9:02 ` Heiko Schocher
2015-05-18 11:31 ` Shawn Guo
2015-05-18 11:31 ` Shawn Guo
2015-05-18 11:31 ` Shawn Guo
2015-05-19 7:09 ` Heiko Schocher
2015-05-19 7:09 ` Heiko Schocher
2015-05-19 7:43 ` Shawn Guo [this message]
2015-05-19 7:43 ` Shawn Guo
2015-05-19 8:48 ` Philipp Zabel
2015-05-19 8:48 ` Philipp Zabel
2015-05-19 13:44 ` Heiko Schocher
2015-05-19 13:44 ` Heiko Schocher
2015-05-19 14:33 ` Philipp Zabel
2015-05-19 14:33 ` Philipp Zabel
2015-05-20 5:14 ` Heiko Schocher
2015-05-20 5:14 ` Heiko Schocher
2015-05-20 5:14 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519074314.GT1071@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.