From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mikko Perttunen
<mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] memory: tegra: Expose supported rates via debugfs
Date: Tue, 19 May 2015 16:36:39 +0200 [thread overview]
Message-ID: <20150519143637.GF26748@ulmo.nvidia.com> (raw)
In-Reply-To: <CAAObsKCo7x4qMdPvBb-dNoN=j7Od-eMCxw9BNoSvDR5mUZXGtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Tue, May 19, 2015 at 02:21:01PM +0200, Tomeu Vizoso wrote:
> On 18 May 2015 at 17:35, Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > In order to ease testing, expose the list of supported EMC frequencies
> > via debugfs.
>
> Looks good to me, but if this is for automated testing, why not just
> read the timings from the DT? We would be covering more code that way.
>
> Reviewed-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
The idea is that by putting this into debugfs we have a single source of
information to use in tests.
Now if in addition to merely testing the frequencies you want to make
sure the driver has a consistent representation of what's in device tree
we could always write another test that reads the device tree nodes and
compares them to the list of supported rates from debugfs.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] memory: tegra: Expose supported rates via debugfs
Date: Tue, 19 May 2015 16:36:39 +0200 [thread overview]
Message-ID: <20150519143637.GF26748@ulmo.nvidia.com> (raw)
In-Reply-To: <CAAObsKCo7x4qMdPvBb-dNoN=j7Od-eMCxw9BNoSvDR5mUZXGtA@mail.gmail.com>
On Tue, May 19, 2015 at 02:21:01PM +0200, Tomeu Vizoso wrote:
> On 18 May 2015 at 17:35, Thierry Reding <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > In order to ease testing, expose the list of supported EMC frequencies
> > via debugfs.
>
> Looks good to me, but if this is for automated testing, why not just
> read the timings from the DT? We would be covering more code that way.
>
> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
The idea is that by putting this into debugfs we have a single source of
information to use in tests.
Now if in addition to merely testing the frequencies you want to make
sure the driver has a consistent representation of what's in device tree
we could always write another test that reads the device tree nodes and
compares them to the list of supported rates from debugfs.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150519/9abd9450/attachment.sig>
next prev parent reply other threads:[~2015-05-19 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 15:35 [PATCH] memory: tegra: Expose supported rates via debugfs Thierry Reding
2015-05-18 15:35 ` Thierry Reding
[not found] ` <1431963330-25708-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-19 12:21 ` Tomeu Vizoso
2015-05-19 12:21 ` Tomeu Vizoso
[not found] ` <CAAObsKCo7x4qMdPvBb-dNoN=j7Od-eMCxw9BNoSvDR5mUZXGtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-19 14:36 ` Thierry Reding [this message]
2015-05-19 14:36 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519143637.GF26748@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.