All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 2/2] ARM: vf610: Add SoC bus support for Vybrid
Date: Wed, 20 May 2015 09:01:51 +0800	[thread overview]
Message-ID: <20150520010151.GZ1071@dragon> (raw)
In-Reply-To: <20150519094223.GA3194@Sanchayan-Arch.toradex.int>

On Tue, May 19, 2015 at 03:12:23PM +0530, maitysanchayan at gmail.com wrote:
> Hello Shawn,
> 
> On 15-05-19 14:24:13, Shawn Guo wrote:
> > On Mon, May 18, 2015 at 11:50:07AM +0530, Sanchayan Maity wrote:
> > > Implements SoC bus support to export SoC specific information. Read
> > > the unique SoC ID from the Vybrid On Chip One Time Programmable
> > > (OCOTP) controller, SoC specific information from the Miscellaneous
> > > System Control Module (MSCM), revision from the ROM revision register
> > > and expose it via the SoC bus infrastructure.
> > > 
> > > Sample Output:
> > > 
> > > root at vf:/sys/devices/soc0# cat soc_id
> > > df63c12a2e2161d4
> > > root at vf:/sys/devices/soc0# cat family
> > > Freescale Vybrid VF500
> > > root at vf:/sys/devices/soc0# cat revision
> > > 00000013
> > > root at vf:/sys/devices/soc0# cat machine
> > > Freescale Vybrid
> > > 
> > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > > ---
> > >  arch/arm/mach-imx/mach-vf610.c | 81 ++++++++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 81 insertions(+)
> > > 
> > > diff --git a/arch/arm/mach-imx/mach-vf610.c b/arch/arm/mach-imx/mach-vf610.c
> > > index 2e7c75b..64c78e4 100644
> > > --- a/arch/arm/mach-imx/mach-vf610.c
> > > +++ b/arch/arm/mach-imx/mach-vf610.c
> > > @@ -11,6 +11,86 @@
> > >  #include <linux/irqchip.h>
> > >  #include <asm/mach/arch.h>
> > >  #include <asm/hardware/cache-l2x0.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/sys_soc.h>
> > > +#include <linux/mfd/syscon.h>
> > > +#include <linux/regmap.h>
> > > +#include <linux/random.h>
> > 
> > Please group <linux/*> headers together and sort alphabetically.
> 
> Ok. Will fix this and send out a v2. The rest is acceptable?

I'm fine with the rest, but would need an ACK from Stefan to apply the
patch.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: maitysanchayan@gmail.com
Cc: shawn.guo@linaro.org, kernel@pengutronix.de, stefan@agner.ch,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] ARM: vf610: Add SoC bus support for Vybrid
Date: Wed, 20 May 2015 09:01:51 +0800	[thread overview]
Message-ID: <20150520010151.GZ1071@dragon> (raw)
In-Reply-To: <20150519094223.GA3194@Sanchayan-Arch.toradex.int>

On Tue, May 19, 2015 at 03:12:23PM +0530, maitysanchayan@gmail.com wrote:
> Hello Shawn,
> 
> On 15-05-19 14:24:13, Shawn Guo wrote:
> > On Mon, May 18, 2015 at 11:50:07AM +0530, Sanchayan Maity wrote:
> > > Implements SoC bus support to export SoC specific information. Read
> > > the unique SoC ID from the Vybrid On Chip One Time Programmable
> > > (OCOTP) controller, SoC specific information from the Miscellaneous
> > > System Control Module (MSCM), revision from the ROM revision register
> > > and expose it via the SoC bus infrastructure.
> > > 
> > > Sample Output:
> > > 
> > > root@vf:/sys/devices/soc0# cat soc_id
> > > df63c12a2e2161d4
> > > root@vf:/sys/devices/soc0# cat family
> > > Freescale Vybrid VF500
> > > root@vf:/sys/devices/soc0# cat revision
> > > 00000013
> > > root@vf:/sys/devices/soc0# cat machine
> > > Freescale Vybrid
> > > 
> > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > > ---
> > >  arch/arm/mach-imx/mach-vf610.c | 81 ++++++++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 81 insertions(+)
> > > 
> > > diff --git a/arch/arm/mach-imx/mach-vf610.c b/arch/arm/mach-imx/mach-vf610.c
> > > index 2e7c75b..64c78e4 100644
> > > --- a/arch/arm/mach-imx/mach-vf610.c
> > > +++ b/arch/arm/mach-imx/mach-vf610.c
> > > @@ -11,6 +11,86 @@
> > >  #include <linux/irqchip.h>
> > >  #include <asm/mach/arch.h>
> > >  #include <asm/hardware/cache-l2x0.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/sys_soc.h>
> > > +#include <linux/mfd/syscon.h>
> > > +#include <linux/regmap.h>
> > > +#include <linux/random.h>
> > 
> > Please group <linux/*> headers together and sort alphabetically.
> 
> Ok. Will fix this and send out a v2. The rest is acceptable?

I'm fine with the rest, but would need an ACK from Stefan to apply the
patch.

Shawn

  reply	other threads:[~2015-05-20  1:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18  6:20 [PATCH v1 0/2] Implement SoC bus support for Vybrid Sanchayan Maity
2015-05-18  6:20 ` Sanchayan Maity
2015-05-18  6:20 ` Sanchayan Maity
2015-05-18  6:20 ` [PATCH v1 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes Sanchayan Maity
2015-05-18  6:20   ` Sanchayan Maity
2015-05-18  6:20   ` Sanchayan Maity
2015-05-18  6:20 ` [PATCH v1 2/2] ARM: vf610: Add SoC bus support for Vybrid Sanchayan Maity
2015-05-18  6:20   ` Sanchayan Maity
2015-05-18  6:20   ` Sanchayan Maity
2015-05-19  6:24   ` Shawn Guo
2015-05-19  6:24     ` Shawn Guo
2015-05-19  9:42     ` maitysanchayan at gmail.com
2015-05-19  9:42       ` maitysanchayan
2015-05-20  1:01       ` Shawn Guo [this message]
2015-05-20  1:01         ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520010151.GZ1071@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.