All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Sergej Sawazki <ce3a@gmx.de>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: wm8741: check for error returns from wm8741_set_pdata()
Date: Wed, 20 May 2015 08:48:32 +0100	[thread overview]
Message-ID: <20150520074832.GB31187@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150520074035.GB18278@mwanda>

On Wed, May 20, 2015 at 10:40:35AM +0300, Dan Carpenter wrote:
> Static checkers complain that "ret" is always zero so the conditions are
> never true.
> 
> The intention here was clearly to check for errors from
> wm8741_set_pdata().  Although, since wm8741_set_pdata() never returns
> errors, it doesn't affect runtime.
> 
> Fixes: c354b54cfdf6 ('ASoC: wm8741: Add differential mono mode support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Sergej Sawazki <ce3a@gmx.de>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: wm8741: check for error returns from wm8741_set_pdata()
Date: Wed, 20 May 2015 07:48:32 +0000	[thread overview]
Message-ID: <20150520074832.GB31187@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150520074035.GB18278@mwanda>

On Wed, May 20, 2015 at 10:40:35AM +0300, Dan Carpenter wrote:
> Static checkers complain that "ret" is always zero so the conditions are
> never true.
> 
> The intention here was clearly to check for errors from
> wm8741_set_pdata().  Although, since wm8741_set_pdata() never returns
> errors, it doesn't affect runtime.
> 
> Fixes: c354b54cfdf6 ('ASoC: wm8741: Add differential mono mode support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

  reply	other threads:[~2015-05-20  7:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  7:40 [patch] ASoC: wm8741: check for error returns from wm8741_set_pdata() Dan Carpenter
2015-05-20  7:40 ` Dan Carpenter
2015-05-20  7:48 ` Charles Keepax [this message]
2015-05-20  7:48   ` Charles Keepax
2015-05-20  9:55 ` Mark Brown
2015-05-20  9:55   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520074832.GB31187@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ce3a@gmx.de \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.