From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 7/7] ARM: dts: sun9i: Add secure SRAM node used for MCPM SMP hotplug
Date: Wed, 20 May 2015 12:08:31 +0200 [thread overview]
Message-ID: <20150520100831.GE4004@lukather> (raw)
In-Reply-To: <1431583811-25780-8-git-send-email-wens@csie.org>
On Thu, May 14, 2015 at 02:10:11PM +0800, Chen-Yu Tsai wrote:
> The A80 stores some magic flags in a portion of the secure SRAM. The
> BROM jumps directly to the software entry point set by the SMP code
> if the flags are set. This is required for CPU0 hotplugging.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun9i-a80.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> index 1507bd2a88f0..0695215634d4 100644
> --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> @@ -366,6 +366,26 @@
> */
> ranges = <0 0 0 0x20000000>;
>
> + sram_b: sram at 00020000 {
> + /* 256 KiB secure SRAM at 0x20000 */
> + compatible = "mmio-sram";
> + reg = <0x00020000 0x40000>;
> +
We should probably add a property to that SRAM to tell the driver not
to access it if we're not booted in secure mode.
Otherwise, bad things might happen.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150520/f4294a49/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [RFC 7/7] ARM: dts: sun9i: Add secure SRAM node used for MCPM SMP hotplug
Date: Wed, 20 May 2015 12:08:31 +0200 [thread overview]
Message-ID: <20150520100831.GE4004@lukather> (raw)
In-Reply-To: <1431583811-25780-8-git-send-email-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
On Thu, May 14, 2015 at 02:10:11PM +0800, Chen-Yu Tsai wrote:
> The A80 stores some magic flags in a portion of the secure SRAM. The
> BROM jumps directly to the software entry point set by the SMP code
> if the flags are set. This is required for CPU0 hotplugging.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun9i-a80.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> index 1507bd2a88f0..0695215634d4 100644
> --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> @@ -366,6 +366,26 @@
> */
> ranges = <0 0 0 0x20000000>;
>
> + sram_b: sram@00020000 {
> + /* 256 KiB secure SRAM at 0x20000 */
> + compatible = "mmio-sram";
> + reg = <0x00020000 0x40000>;
> +
We should probably add a property to that SRAM to tell the driver not
to access it if we're not booted in secure mode.
Otherwise, bad things might happen.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-20 10:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 6:10 [RFC 0/7] ARM: sun9i: SMP support with Multi-Cluster Power Management Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-14 6:10 ` [RFC 1/7] ARM: sun9i: Support SMP on A80 with Multi-Cluster Power Management (MCPM) Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-14 6:10 ` [RFC 2/7] ARM: dts: sun9i: Add CCI-400 device nodes for A80 Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-17 14:51 ` Maxime Ripard
2015-05-17 14:51 ` Maxime Ripard
2015-05-19 7:12 ` Chen-Yu Tsai
2015-05-19 7:12 ` Chen-Yu Tsai
2015-05-14 6:10 ` [RFC 3/7] ARM: dts: sun9i: Add CPUCFG device node for A80 dtsi Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-14 6:10 ` [RFC 4/7] ARM: dts: sun9i: Add PRCM device node for the " Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-17 14:54 ` Maxime Ripard
2015-05-17 14:54 ` Maxime Ripard
2015-05-19 3:08 ` Chen-Yu Tsai
2015-05-19 3:08 ` Chen-Yu Tsai
2015-05-14 6:10 ` [RFC 5/7] ARM: sunxi: mcpm: Support CPU/cluster power down and hotplugging for cpu1~7 Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-14 6:10 ` [RFC 6/7] ARM: sunxi: mcpm: Support cpu0 hotplug Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-14 6:10 ` [RFC 7/7] ARM: dts: sun9i: Add secure SRAM node used for MCPM SMP hotplug Chen-Yu Tsai
2015-05-14 6:10 ` Chen-Yu Tsai
2015-05-20 10:08 ` Maxime Ripard [this message]
2015-05-20 10:08 ` Maxime Ripard
2015-05-24 15:55 ` [linux-sunxi] " Chen-Yu Tsai
2015-05-24 15:55 ` Chen-Yu Tsai
2015-05-25 21:24 ` Maxime Ripard
2015-05-25 21:24 ` Maxime Ripard
2015-05-26 16:47 ` Chen-Yu Tsai
2015-05-26 16:47 ` Chen-Yu Tsai
2015-06-11 16:33 ` Maxime Ripard
2015-06-11 16:33 ` Maxime Ripard
2015-05-16 10:08 ` [linux-sunxi] [RFC 0/7] ARM: sun9i: SMP support with Multi-Cluster Power Management Ian Campbell
2015-05-16 10:08 ` Ian Campbell
2015-05-17 14:38 ` Maxime Ripard
2015-05-17 14:38 ` Maxime Ripard
2015-05-18 5:19 ` Nicolas Pitre
2015-05-18 5:19 ` Nicolas Pitre
2015-05-18 9:04 ` Maxime Ripard
2015-05-18 9:04 ` Maxime Ripard
2015-05-19 2:51 ` Chen-Yu Tsai
2015-05-19 2:51 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520100831.GE4004@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.