Re: [PATCH 4/6] i2c-parport: use new parport device model

[Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > Modify i2c-parport driver to use the new parallel port device model.
> > 
> > Tested-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
> > Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
> > ---
> 
> In general:
> 
> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> 
> >  static struct parport_driver i2c_parport_driver = {
> > -	.name	= "i2c-parport",
> > -	.attach	= i2c_parport_attach,
> > -	.detach	= i2c_parport_detach,
> > +	.name		= "i2c-parport",
> > +	.match_port	= i2c_parport_attach,
> > +	.detach		= i2c_parport_detach,
> > +	.devmodel	= true,
> 
> Minor nit: I prefer to not use tabs but a single space after the struct
> member names. Less hazzle in the future and still readable IMO.
It was having space originally. I changed that into tab as it was
looking good with them as aligned.
I will wait today for some more review and send v2 tomorrow with this
chanage.

regards
sudip
>