From: Oleg Nesterov <oleg@redhat.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Peter Zijlstra <peterz@infradead.org>,
Nicholas Mc Guire <hofrat@osadl.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking: type cleanup when accessing fast_read_ctr
Date: Wed, 20 May 2015 19:44:31 +0200 [thread overview]
Message-ID: <20150520174431.GB6831@redhat.com> (raw)
In-Reply-To: <20150519112513.GA1337@opentech.at>
On 05/19, Nicholas Mc Guire wrote:
>
> I assumed it would not matter but did not see a simple way of getting it
> type clean with unsigned either mainly due to the atomic_t being int and
> val in update_fast_ctr() being passed as -1.
Perhaps clear_fast_ctr() should have a comment to explain why it returns
"int"... even if "unsigned" should work too.
Please see https://lkml.org/lkml/2012/11/2/346
Oleg.
next prev parent reply other threads:[~2015-05-20 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:48 [PATCH] locking: type cleanup when accessing fast_read_ctr Nicholas Mc Guire
2015-05-19 11:11 ` Peter Zijlstra
2015-05-19 11:25 ` Nicholas Mc Guire
2015-05-20 17:44 ` Oleg Nesterov [this message]
2015-05-23 6:46 ` Nicholas Mc Guire
2015-05-23 9:23 ` Nicholas Mc Guire
2015-05-24 18:18 ` Oleg Nesterov
2015-05-25 5:46 ` Nicholas Mc Guire
2015-05-20 17:42 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520174431.GB6831@redhat.com \
--to=oleg@redhat.com \
--cc=der.herr@hofr.at \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.