From: Luis Henriques <luis.henriques@canonical.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: JBottomley@odin.com, hch@lst.de,
Praveen Murali <pmurali@logicube.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] libsas: fix "sysfs group not found" warnings at port teardown time
Date: Wed, 20 May 2015 23:52:17 +0100 [thread overview]
Message-ID: <20150520225217.GA3058@charon> (raw)
In-Reply-To: <20150520220858.15073.8982.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, May 20, 2015 at 06:09:09PM -0400, Dan Williams wrote:
> Praveen reports:
>
> ---
>
Just a minor comment, not related with the patch itself but with the
commit message: the line above will cause major pain to anyone
applying this patch using 'git am'. This is because git-mailinfo,
when splitting the patch from the message, will assume the message
stops here.
git-am(1) documents this behaviour, the commit message ends with:
- three-dashes and end-of-line, or
- a line that begins with "diff -", or
- a line that begins with "Index: "
Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Luis Henriques <luis.henriques@canonical.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: JBottomley@odin.com, hch@lst.de,
Praveen Murali <pmurali@logicube.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] libsas: fix "sysfs group not found" warnings at port teardown time
Date: Wed, 20 May 2015 23:52:17 +0100 [thread overview]
Message-ID: <20150520225217.GA3058@charon> (raw)
In-Reply-To: <20150520220858.15073.8982.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, May 20, 2015 at 06:09:09PM -0400, Dan Williams wrote:
> Praveen reports:
>
> ---
>
Just a minor comment, not related with the patch itself but with the
commit message: the line above will cause major pain to anyone
applying this patch using 'git am'. This is because git-mailinfo,
when splitting the patch from the message, will assume the message
stops here.
git-am(1) documents this behaviour, the commit message ends with:
- three-dashes and end-of-line, or
- a line that begins with "diff -", or
- a line that begins with "Index: "
Cheers,
--
Lu�s
next prev parent reply other threads:[~2015-05-20 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 22:09 [PATCH] libsas: fix "sysfs group not found" warnings at port teardown time Dan Williams
2015-05-20 22:52 ` Luis Henriques [this message]
2015-05-20 22:52 ` Luis Henriques
2017-01-11 6:29 ` [PATCH] libsas: fix \"sysfs group not found\" " seeteena
2017-01-11 9:10 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520225217.GA3058@charon \
--to=luis.henriques@canonical.com \
--cc=JBottomley@odin.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=pmurali@logicube.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.