From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, arm@kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [GIT PULL 2/2] omap1 sparse irq support for v4.2
Date: Thu, 21 May 2015 14:47:11 -0700 [thread overview]
Message-ID: <20150521214710.GX10274@atomide.com> (raw)
In-Reply-To: <6774083.RmPqVFIumd@wuerfel>
* Arnd Bergmann <arnd@arndb.de> [150521 14:35]:
> On Thursday 21 May 2015 11:36:30 Tony Lindgren wrote:
> > >
> > > OK got it triggered here too with randconfig builds now.
> > > This seems to be related to not selecting some omap1 SoCs or
> > > boards. I'll try to do a minimal fix for it today.
> > >
> > > It seems the include changes you posted would be better done
> > > by replacing the the dependencies to mach/irqs.h where possible
> > > rather than adding more includes?
>
> Yes, I guess we can do that too. FWIW, almost all the problems
> were uses of cpu_is_omap*(), omap_read*() and omap_write*().
>
> There are quite a lot of them overall, but at least they are
> easy to grep for, and there should be an obvious fix for each
> of them, following what you did on OMAP2 a couple of years ago.
Yeah then that can be done one driver at a time.
> > OK figured it out. We now rely on an indirect include selected
> > with ARCH_OMAP15XX. Here's what I suggest as a fix for this
> > issue, obviously the real fix is to fix the legacy drivers to not
> > #include <mach/*.h>.
>
> Ok, I've put this patch in my randconfig build setup to replace
> my older patch, let's see if there are still some corner cases
> left. So far, everything looks good (50 random mach-omap1 builds
> done). Can you send an updated pull request with the fix folded in?
OK will do. I'll also include the secion warning I posted earlier
today as that seems to get triggered with some randconfigs because
of the __init_or_module.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL 2/2] omap1 sparse irq support for v4.2
Date: Thu, 21 May 2015 14:47:11 -0700 [thread overview]
Message-ID: <20150521214710.GX10274@atomide.com> (raw)
In-Reply-To: <6774083.RmPqVFIumd@wuerfel>
* Arnd Bergmann <arnd@arndb.de> [150521 14:35]:
> On Thursday 21 May 2015 11:36:30 Tony Lindgren wrote:
> > >
> > > OK got it triggered here too with randconfig builds now.
> > > This seems to be related to not selecting some omap1 SoCs or
> > > boards. I'll try to do a minimal fix for it today.
> > >
> > > It seems the include changes you posted would be better done
> > > by replacing the the dependencies to mach/irqs.h where possible
> > > rather than adding more includes?
>
> Yes, I guess we can do that too. FWIW, almost all the problems
> were uses of cpu_is_omap*(), omap_read*() and omap_write*().
>
> There are quite a lot of them overall, but at least they are
> easy to grep for, and there should be an obvious fix for each
> of them, following what you did on OMAP2 a couple of years ago.
Yeah then that can be done one driver at a time.
> > OK figured it out. We now rely on an indirect include selected
> > with ARCH_OMAP15XX. Here's what I suggest as a fix for this
> > issue, obviously the real fix is to fix the legacy drivers to not
> > #include <mach/*.h>.
>
> Ok, I've put this patch in my randconfig build setup to replace
> my older patch, let's see if there are still some corner cases
> left. So far, everything looks good (50 random mach-omap1 builds
> done). Can you send an updated pull request with the fix folded in?
OK will do. I'll also include the secion warning I posted earlier
today as that seems to get triggered with some randconfigs because
of the __init_or_module.
Regards,
Tony
next prev parent reply other threads:[~2015-05-21 21:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 12:11 [GIT PULL 2/2] omap1 sparse irq support for v4.2 Arnd Bergmann
2015-05-21 14:58 ` Tony Lindgren
2015-05-21 14:58 ` Tony Lindgren
2015-05-21 15:40 ` Arnd Bergmann
2015-05-21 15:40 ` Arnd Bergmann
2015-05-21 15:49 ` Tony Lindgren
2015-05-21 15:49 ` Tony Lindgren
2015-05-21 16:54 ` Tony Lindgren
2015-05-21 16:54 ` Tony Lindgren
2015-05-21 18:36 ` Tony Lindgren
2015-05-21 18:36 ` Tony Lindgren
2015-05-21 21:33 ` Arnd Bergmann
2015-05-21 21:33 ` Arnd Bergmann
2015-05-21 21:47 ` Tony Lindgren [this message]
2015-05-21 21:47 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2015-05-21 12:14 Arnd Bergmann
2015-05-21 12:47 ` Arnd Bergmann
2015-05-21 12:47 ` Arnd Bergmann
2015-05-20 22:36 [GIT PULL 1/2] omap clean-up " Tony Lindgren
2015-05-20 22:36 ` [GIT PULL 2/2] omap1 sparse irq support " Tony Lindgren
2015-05-20 22:36 ` Tony Lindgren
2015-05-20 22:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521214710.GX10274@atomide.com \
--to=tony@atomide.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.