From: Viresh Kumar <viresh.kumar@linaro.org>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match.
Date: Fri, 22 May 2015 07:47:30 +0530 [thread overview]
Message-ID: <20150522021730.GA7730@linux> (raw)
In-Reply-To: <1432232981-3917-1-git-send-email-shailendra.capricorn@gmail.com>
On 21-05-15, 23:59, Shailendra Verma wrote:
> During probe free the memory allocated to "exynos_info" in case of unknown
> SOC type.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 82d2fbb..b77923a 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -182,6 +182,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
> ret = exynos5250_cpufreq_init(exynos_info);
> } else {
> pr_err("%s: Unknown SoC type\n", __func__);
> + kfree(exynos_info);
> return -ENODEV;
> }
There is no point replicating this stuff. Use labels like: err_vdd_arm
to get this done. But you also need to make sure the right error gets
propagated.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match.
Date: Fri, 22 May 2015 07:47:30 +0530 [thread overview]
Message-ID: <20150522021730.GA7730@linux> (raw)
In-Reply-To: <1432232981-3917-1-git-send-email-shailendra.capricorn@gmail.com>
On 21-05-15, 23:59, Shailendra Verma wrote:
> During probe free the memory allocated to "exynos_info" in case of unknown
> SOC type.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 82d2fbb..b77923a 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -182,6 +182,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
> ret = exynos5250_cpufreq_init(exynos_info);
> } else {
> pr_err("%s: Unknown SoC type\n", __func__);
> + kfree(exynos_info);
> return -ENODEV;
> }
There is no point replicating this stuff. Use labels like: err_vdd_arm
to get this done. But you also need to make sure the right error gets
propagated.
--
viresh
next prev parent reply other threads:[~2015-05-22 2:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 18:29 [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match Shailendra Verma
2015-05-21 18:29 ` Shailendra Verma
2015-05-22 2:17 ` Viresh Kumar [this message]
2015-05-22 2:17 ` Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2015-05-23 3:02 Shailendra Verma
2015-05-23 3:02 ` Shailendra Verma
2015-05-23 4:42 ` Viresh Kumar
2015-05-23 4:42 ` Viresh Kumar
2015-05-25 2:09 Shailendra Verma
2015-05-25 2:09 ` Shailendra Verma
2015-05-25 7:31 ` Viresh Kumar
2015-05-25 7:31 ` Viresh Kumar
2015-06-08 8:31 ` Lukasz Majewski
2015-06-08 8:31 ` Lukasz Majewski
2015-06-08 23:30 ` Rafael J. Wysocki
2015-06-08 23:30 ` Rafael J. Wysocki
2015-06-09 7:07 ` Lukasz Majewski
2015-06-09 7:07 ` Lukasz Majewski
2015-06-09 7:23 ` Krzysztof Kozlowski
2015-06-09 7:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522021730.GA7730@linux \
--to=viresh.kumar@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shailendra.capricorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.